DataGrid - AI Column is empty in the adaptive row #31909

dmlvr · 2025-12-02T16:53:21Z

No description provided.

Copilot

Pull request overview

This PR fixes an issue where AI column values were not properly displayed in adaptive detail rows (the expandable rows shown when columns are hidden due to responsive layout). The problem occurred because the adaptive detail row rendering was attempting to recalculate AI column values using calculateCellValue(), but AI column values are stored in a cache and should be retrieved from the already-calculated row.values array.

Key Changes

Added special handling for AI columns in adaptive detail rows to retrieve values from the pre-calculated row.values array instead of recalculating them
Extracted value retrieval logic into a reusable _getValueFromCellOptions method
Added comprehensive E2E test to verify AI column values display correctly in adaptive detail rows

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts`	Added import for `AI_COLUMN_NAME` constant, created `_getValueFromCellOptions` helper method, and added conditional logic to use pre-calculated values for AI columns in adaptive detail rows
`e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts`	Updated fixture to use container with AI integration support and added new test case that verifies AI column values appear correctly in adaptive detail rows

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts

…ity.functional.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts

packages/testcafe-models/dataGrid/adaptiveDetailRow.ts

dmirgaev · 2025-12-05T06:34:41Z

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts

+  delete (window as any).aiResolve;
+});
+
+test('The AI column should have value in the adaptive detail row', async (t) => {


What was the reason to move this test up? I wonder if it can be a problem for future us (=

This is not key change for test. The key change is fixture without disablePageReloads in the test file.

I moved test to the bottom of the file and it's green.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts

update _renderFormViewTemplate for ai column

233394a

dmlvr self-assigned this Dec 2, 2025

dmlvr added 2 commits December 3, 2025 13:20

add _getValueFromCellOptions for adaptivity controller

a947a88

write test for this case

4d5cbe9

dmlvr force-pushed the ai_column_25_2_is_empty_adaptive_row branch from bd841a4 to 4d5cbe9 Compare December 4, 2025 10:01

dmlvr marked this pull request as ready for review December 4, 2025 10:01

dmlvr requested a review from a team as a code owner December 4, 2025 10:01

Copilot AI review requested due to automatic review settings December 4, 2025 10:01

dmlvr changed the title ~~ai column empty adaptive row~~ DataGrid - AI Column is empty in the adaptive row Dec 4, 2025

dmlvr added the 25_2 label Dec 4, 2025

Copilot started reviewing on behalf of dmlvr December 4, 2025 10:04 View session

Copilot finished reviewing on behalf of dmlvr December 4, 2025 10:07

Copilot AI reviewed Dec 4, 2025

View reviewed changes

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts Outdated Show resolved Hide resolved

Update e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptiv…

d12635d

…ity.functional.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 4, 2025 10:18

Copilot started reviewing on behalf of dmlvr December 4, 2025 10:19 View session

Copilot finished reviewing on behalf of dmlvr December 4, 2025 10:22

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Apply suggestion from @Copilot

512354b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 4, 2025 10:39

Apply suggestion from @Copilot

8eec8a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot started reviewing on behalf of dmlvr December 4, 2025 10:40 View session

Apply suggestion from @Copilot

08a035a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

Copilot finished reviewing on behalf of dmlvr December 4, 2025 10:43

used visibleIndex for getting value from cellOptions

798f1fe

Copilot AI reviewed Dec 4, 2025

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts Show resolved Hide resolved

dmlvr added 2 commits December 4, 2025 12:55

change test for CI working

96c60b8

update aiIntegration in test

6bfb0a5

Copilot AI review requested due to automatic review settings December 4, 2025 12:04

Copilot started reviewing on behalf of dmlvr December 4, 2025 12:05 View session

Copilot finished reviewing on behalf of dmlvr December 4, 2025 12:06

dmirgaev previously approved these changes Dec 4, 2025

View reviewed changes

Copilot AI reviewed Dec 4, 2025

View reviewed changes

dmlvr added the skip-cache label Dec 4, 2025

some updates for test

42f9c1f

dmlvr dismissed dmirgaev’s stale review via 42f9c1f December 4, 2025 12:49

dmlvr added the force all tests label Dec 4, 2025

test optimization

bd1be82

Copilot AI review requested due to automatic review settings December 4, 2025 13:20

Copilot started reviewing on behalf of dmlvr December 4, 2025 13:21 View session

Copilot finished reviewing on behalf of dmlvr December 4, 2025 13:24

Copilot AI reviewed Dec 4, 2025

View reviewed changes

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts Show resolved Hide resolved

dmirgaev requested changes Dec 5, 2025

View reviewed changes

dmlvr added 2 commits December 5, 2025 09:20

rename getAdaptiveCellByName to getAdaptiveCellByText

b9a1c6d

move test to the bottom og the file

e3b212f

dmlvr removed the force all tests label Dec 5, 2025

fix lint

b2a4d38

Copilot AI review requested due to automatic review settings December 5, 2025 07:43

Copilot started reviewing on behalf of dmlvr December 5, 2025 07:44 View session

Copilot finished reviewing on behalf of dmlvr December 5, 2025 07:48

Copilot AI reviewed Dec 5, 2025

View reviewed changes

e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts Show resolved Hide resolved

dmirgaev approved these changes Dec 5, 2025

View reviewed changes

dmlvr merged commit b768d5f into DevExpress:25_2 Dec 5, 2025
120 of 122 checks passed

DataGrid - AI Column is empty in the adaptive row #31909

DataGrid - AI Column is empty in the adaptive row #31909

Uh oh!

Conversation

dmlvr commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

dmirgaev Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

dmlvr Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dmlvr Dec 5, 2025 •

edited

Loading