Skip to content

Conversation

@Tucchhaa
Copy link
Contributor

No description provided.

@Tucchhaa Tucchhaa self-assigned this Dec 10, 2025
@Tucchhaa Tucchhaa closed this Dec 10, 2025
@Tucchhaa Tucchhaa reopened this Dec 10, 2025
@Tucchhaa Tucchhaa marked this pull request as ready for review December 10, 2025 09:28
@Tucchhaa Tucchhaa requested a review from a team as a code owner December 10, 2025 09:28
Copilot AI review requested due to automatic review settings December 10, 2025 09:28
@Tucchhaa Tucchhaa merged commit 0e6676f into DevExpress:25_2 Dec 10, 2025
96 of 97 checks passed
@Tucchhaa Tucchhaa deleted the fix_icons_25_2 branch December 10, 2025 09:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes icon alignment in the Scheduler appointment form for resources with multiple selection and custom icons. Previously, icons were only aligned for specific groups (description, recurrence settings) but not for resource groups when custom icons were used, resulting in misaligned icons when resources had allowMultiple: true and custom icon properties.

Key Changes:

  • Generalized icon margin-top styling to apply to all form group icons
  • Renamed SCSS variables from *-description-icon-margin-top to *-icon-margin-top for broader applicability
  • Added exceptions for date-range and recurrence-end groups where the margin is not needed
  • Added visual regression test for resource fields with multiple selection and custom icons

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme-scss/scss/widgets/material/scheduler/_sizes.scss Renamed variable from $material-scheduler-appointment-popup-description-icon-margin-top to $material-scheduler-appointment-popup-icon-margin-top across all size variants
packages/devextreme-scss/scss/widgets/material/scheduler/_index.scss Removed theme-specific icon margin selectors (moved to base); passed renamed variable to base mixin
packages/devextreme-scss/scss/widgets/generic/scheduler/_sizes.scss Renamed variable from $generic-scheduler-appointment-popup-description-icon-margin-top to $generic-scheduler-appointment-popup-icon-margin-top across all size variants
packages/devextreme-scss/scss/widgets/generic/scheduler/_index.scss Removed theme-specific icon margin selectors (moved to base); passed renamed variable to base mixin
packages/devextreme-scss/scss/widgets/fluent/scheduler/_sizes.scss Renamed variable from $fluent-scheduler-appointment-popup-description-icon-margin-top to $fluent-scheduler-appointment-popup-icon-margin-top across all size variants
packages/devextreme-scss/scss/widgets/fluent/scheduler/_index.scss Removed theme-specific icon margin selectors (moved to base); passed renamed variable to base mixin
packages/devextreme-scss/scss/widgets/base/scheduler/_index.scss Added general icon margin-top rule with exceptions for date-range and recurrence-end groups; improved selector specificity with .dx-item-content > to correctly target box items
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.visual.ts Added visual test for appointment form with multiple resource selection to verify icon alignment with TagBox editors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants