Skip to content

Conversation

@sjbur
Copy link
Contributor

@sjbur sjbur commented Dec 10, 2025

No description provided.

@sjbur sjbur self-assigned this Dec 10, 2025
@sjbur sjbur added the 25_2 label Dec 10, 2025
@sjbur sjbur marked this pull request as ready for review December 10, 2025 16:54
@sjbur sjbur requested a review from a team as a code owner December 10, 2025 16:54
Copilot AI review requested due to automatic review settings December 10, 2025 16:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a "Today" button to the calendar dropdowns of date editors in the Scheduler's appointment form. The change is implemented by setting showTodayButton: true in the calendar options of the shared date editor configuration function. A visual test is included to capture the appearance of the opened calendar with the Today button.

Key Changes

  • Added showTodayButton: true to calendar options in getStartDateCommonConfig(), which affects start date, end date, and recurrence start date editors
  • Added visual regression test to verify the calendar appearance with the Today button

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/scheduler/appointment_popup/utils.ts Adds showTodayButton: true to the shared date editor configuration, enabling the Today button for start/end date and recurrence start date editors
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.visual.ts Adds visual test that opens the startDate calendar and captures a screenshot to verify the Today button appears correctly

useMaskBehavior: true,
calendarOptions: {
firstDayOfWeek,
showTodayButton: true,
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The recurrence form's "until" date editor (in m_recurrence_form.ts at line 509) doesn't have showTodayButton: true, while the start date and end date editors now have it. For consistency, consider also adding showTodayButton: true to the recurrence "until" date editor's calendarOptions.

Copilot uses AI. Check for mistakes.
@sjbur sjbur merged commit 82ff8fb into DevExpress:25_2 Dec 11, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants