Skip to content

Conversation

@EugeniyKiyashko
Copy link
Contributor

No description provided.

pharret31
pharret31 previously approved these changes Dec 15, 2025
@EugeniyKiyashko EugeniyKiyashko marked this pull request as ready for review December 15, 2025 16:15
@EugeniyKiyashko EugeniyKiyashko requested a review from a team as a code owner December 15, 2025 16:15
Copilot AI review requested due to automatic review settings December 15, 2025 16:15
@EugeniyKiyashko EugeniyKiyashko merged commit 88915fc into DevExpress:25_2 Dec 15, 2025
117 of 118 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves TypeScript compilation issues in React demos for Charts, VectorMap, and Gauges components by converting type-only imports to use the explicit import type syntax. This is required because the tsconfig.react-check.json configuration has verbatimModuleSyntax: true enabled, which enforces explicit type import declarations. The changes enable TypeScript type checking for these previously unchecked demo categories.

Key Changes

  • Converted all type-only imports (interfaces, types, type namespaces) to use explicit import type syntax across 49 files
  • Extended tsconfig.react-check.json to include VectorMap, Charts, and Gauges React demos for type checking
  • Maintained consistent import organization: type imports from the same package follow runtime imports without blank lines, while different packages are separated by blank lines

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

File Description
apps/demos/tsconfig.react-check.json Added VectorMap, Charts, and Gauges React demo patterns to TypeScript include list
apps/demos/Demos/VectorMap/**/React/*.tsx Converted interface props imports (ITooltipProps, ILayerProps, ILegendProps, etc.) to use import type syntax
apps/demos/Demos/Charts/**/React/*.tsx Converted type imports (ChartTypes, PieChartTypes, TreeMapTypes, etc.) and interface props to use import type syntax
apps/demos/Demos/Charts/**/React/data.ts Converted type imports in data files to use import type syntax for type consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants