Skip to content

Conversation

@anna-shakhova
Copy link
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Dec 26, 2025
Copilot AI review requested due to automatic review settings December 26, 2025 08:46
@anna-shakhova anna-shakhova requested a review from a team as a code owner December 26, 2025 08:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances TypeScript coverage and type safety for editor component demos (Switch, TagBox, TextArea, TextBox, Toast, Tooltip, and Validation). The changes include adding proper type annotations, extracting reusable types into separate files, fixing useCallback dependency arrays, and modernizing React patterns.

Key Changes:

  • Added TypeScript type checking for 8 editor demo categories in tsconfig.react-check.json
  • Improved type safety with proper generic type annotations and new type definition files
  • Fixed useCallback/useMemo dependency arrays by removing redundant setState functions
  • Modernized code by replacing React.Fragment with shorthand <> syntax and separating type imports

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/demos/tsconfig.react-check.json Added TypeScript checking for Switch, TagBox, TextArea, TextBox, Toast, Tooltip, and Validation demos
apps/demos/Demos/Validation/Overview/React/App.tsx Added explicit type annotations, separated type imports, fixed useCallback dependencies, added ValidationCallbackData type
apps/demos/Demos/Validation/Overview/ReactJs/App.js Fixed useCallback dependency arrays by removing setState functions
apps/demos/Demos/Tooltip/Overview/React/App.tsx Replaced deprecated ITooltipOptions with TooltipTypes.Properties
apps/demos/Demos/Toast/Stack/React/* Added NotifyStack type extraction, fixed useCallback dependencies, added explicit type annotations
apps/demos/Demos/Toast/Stack/ReactJs/App.js Fixed useCallback dependencies and replaced React.Fragment
apps/demos/Demos/Toast/Overview/React/* Added Product and ToastConfig types, improved type safety throughout component
apps/demos/Demos/Toast/Overview/ReactJs/* Destructured props, fixed useCallback dependencies, replaced React.Fragment
apps/demos/Demos/TextBox/Overview/React/App.tsx Added type annotations for state and callback parameters
apps/demos/Demos/TextArea/Overview/React/* Refactored data.ts to use named exports, added ValueChangeEvent type, improved type annotations
apps/demos/Demos/TextArea/Overview/ReactJs/* Refactored to use named exports and replaced React.Fragment
apps/demos/Demos/TagBox//React/ Added Product types, improved type safety, fixed useCallback dependencies, replaced React.Fragment
apps/demos/Demos/TagBox//ReactJs/ Improved code patterns, fixed useCallback dependencies, replaced React.Fragment
apps/demos/Demos/Switch/Overview/React/App.tsx Added type annotations and improved destructuring pattern
apps/demos/Demos/Switch/Overview/ReactJs/App.js Improved destructuring pattern in callback

@anna-shakhova anna-shakhova merged commit ec8eb14 into DevExpress:26_1 Dec 26, 2025
108 of 111 checks passed
@anna-shakhova anna-shakhova deleted the 26_1-fix-ts-problems-in-demos-editors-part-3 branch December 26, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants