Chart: ArgumentAxisClick is triggered for removed labels (T1317590) #32064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlvr
force-pushed
the
chart_26_1_argumentaxisclick_triggered_for_removed_labels
branch
from
e8492cb to
b44d619
Compare
dmlvr
changed the title
dmlvr
force-pushed
the
chart_26_1_argumentaxisclick_triggered_for_removed_labels
branch
from
b44d619 to
9e02caa
Compare
dmlvr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue T1317590 where the ArgumentAxisClick event was being triggered for axis labels that should have been removed after a dataSource update. The fix ensures that argument axis tick labels are properly cleaned up when the chart's data is refreshed.
Key Changes:
- Added logic to remove major and minor tick labels from argument axes during series data updates
- Added a test to verify that old axis labels are properly removed when the dataSource is updated
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/viz/m_chart.ts | Implements the fix by calling removeLabel() on all major and minor ticks of argument axes in _handleSeriesDataUpdated() before processing the new data |
| packages/devextreme/testing/tests/DevExpress.viz.charts/chart.integration.tests.js | Adds a QUnit test that verifies axis labels from the old dataSource are removed when a new dataSource is applied |
packages/devextreme/testing/tests/DevExpress.viz.charts/chart.integration.tests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.viz.charts/chart.integration.tests.js
Show resolved
Hide resolved
dmlvr
changed the title
pharret31
approved these changes
Dec 30, 2025
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Dec 30, 2025
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Dec 30, 2025
pharret31
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.