Skip to content

DataGrid: Fix column reordering while using fixed columns (T1316881)#32252

Merged
Alyar666 merged 2 commits intoDevExpress:26_1from
Alyar666:T1316881_26_1
Jan 22, 2026
Merged

DataGrid: Fix column reordering while using fixed columns (T1316881)#32252
Alyar666 merged 2 commits intoDevExpress:26_1from
Alyar666:T1316881_26_1

Conversation

@Alyar666
Copy link
Contributor

No description provided.

@Alyar666 Alyar666 self-assigned this Jan 20, 2026
@Alyar666 Alyar666 requested a review from a team as a code owner January 20, 2026 13:45
Copilot AI review requested due to automatic review settings January 20, 2026 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in DataGrid column reordering when using fixed columns with virtual column rendering mode (T1316881). The fix removes incorrect column index offset adjustments that were causing reordering to malfunction.

Changes:

  • Removed column index offset logic from drag-and-drop column reordering operations
  • Updated keyboard navigation to handle column index offset corrections after scrolling
  • Refactored column visibility index calculations to handle virtual rendering mode properly

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
m_headers_keyboard_navigation.ts Added method to correct focused column index after scroll and simplified cell retrieval
m_column_keyboard_navigation_core.ts Removed column index offset adjustments from visibility index calculations
m_columns_resizing_reordering.ts Removed addColumnIndexOffset method and its usage from drag-and-drop operations
types.ts Added type definitions for column index and drop location names
m_columns_controller_utils.ts Refactored getColumnIndexByVisibleIndex to properly handle virtual rendering mode with column offsets
const.ts Added constants for virtual command column and headers location
visual.ts Added visual regression tests for column reordering scenarios
functional.ts Added functional tests for column reordering with fixed columns and virtual rendering
columnReordering.ts Moved existing tests to separate functional.ts and visual.ts files

Copilot AI review requested due to automatic review settings January 21, 2026 20:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.

@Alyar666 Alyar666 merged commit 552a4f8 into DevExpress:26_1 Jan 22, 2026
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants