Lookup, Popover: Remove skipped tests #32303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zedwag
approved these changes
Jan 26, 2026
marker-dao
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two skipped (QUnit.skip) tests from the test suites for Popover and Lookup widgets. These tests were previously disabled and are now being cleaned up from the codebase.
Changes:
- Removed a skipped Popover test that was checking arrow positioning when popup-content is manually hidden
- Removed a skipped Lookup test that was checking onContentReady behavior after input rendering with deferRendering=true
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/popover.tests.js | Removed skipped test for arrow positioning edge case when popup-content is hidden |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js | Removed skipped test for onContentReady timing with deferRendering=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.