List: fix border cases on dragging first or last items using KBN (T1320189) #32334
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a list keyboard-reordering edge case where using Shift+Arrow on boundary items could cause a runtime error, and adds regression tests to cover the behavior.
Changes:
- Guard
ListEdit’s keyboard-based reordering logic against missing destination items so Shift+Arrow on out-of-range indices exits safely without throwing. - Add QUnit tests to verify that Shift+ArrowUp on the first item and Shift+ArrowDown on the last item do not throw and keep the item order unchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/list/list.edit.ts |
Adds a null check for the next item element before computing group boundaries and calling reorderItem, preventing a TypeError when trying to move beyond list bounds. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js |
Introduces two keyboard navigation tests that reproduce the Shift+ArrowUp/Down boundary scenarios and assert that the items order remains unchanged (regression coverage for T1320189). |
pharret31
reviewed
Jan 28, 2026
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js
Show resolved
Hide resolved
pharret31
approved these changes
Jan 29, 2026
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jan 30, 2026
…'get') occurs when using Shift + Up Arrow on the first item (DevExpress#32334)
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jan 30, 2026
…'get') occurs when using Shift + Up Arrow on the first item (DevExpress#32334)
pharret31
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.