Skip to content

DataGrid - TestCafe tests - Scrolling: Fix skipped tests #32361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmirgaev merged 12 commits into from
Feb 4, 2026
+76 −41
Merged

DataGrid - TestCafe tests - Scrolling: Fix skipped tests #32361

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
27c3316
disable tests skipping
dmirgaev Jan 30, 2026
95ffb73
fix the first skipped test
dmirgaev Feb 2, 2026
889949e
fix the second skipped test
dmirgaev Feb 2, 2026
f8a82f7
fix the third skipped test
dmirgaev Feb 2, 2026
654bc32
fix the fourth skipped test
dmirgaev Feb 2, 2026
bf9e6fa
fix the fifth skipped test
dmirgaev Feb 2, 2026
2474415
rename vars
dmirgaev Feb 3, 2026
993a7f9
get rid of private option "loadingTimeout" in the first skipped test
dmirgaev Feb 3, 2026
026ace2
revert the last test changes as it will be fixed in a separate task
dmirgaev Feb 3, 2026
1d65e02
launch theme dependant tests with forced theme
dmirgaev Feb 3, 2026
8dec79c
make tests theme independent
dmirgaev Feb 3, 2026
72a3a36
return back default theme
dmirgaev Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 76 additions & 41 deletions e2e/testcafe-devextreme/tests/dataGrid/common/scrolling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ClientFunction, Selector } from 'testcafe';
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
import DataGrid from 'devextreme-testcafe-models/dataGrid';
import { ClassNames as CLASS } from 'devextreme-testcafe-models/dataGrid/classNames';
import { ClassNames } from 'devextreme-testcafe-models/dataGrid/classNames';
import { insertStylesheetRulesToPage } from '../../../helpers/domUtils';
import url from '../../../helpers/getPageUrl';
import { createWidget } from '../../../helpers/createWidget';
Expand Down Expand Up @@ -225,16 +225,27 @@ test('DataGrid should not reset its top scroll position after cell modification
},
}));

test.meta({ unstable: true })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => {
// Theme dependent test
test.meta({ runInTheme: Themes.fluentBlue })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => {
Copy link
Contributor

@anna-shakhova anna-shakhova Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test.meta({ runInTheme: Themes.fluentBlue })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => {
test('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => {

there is no need in runInTheme meta - by default tests run only in fluent.blue theme
we use this flag if we do not want test to be run in fluent theme and instead run it in some other theme

Copy link
Contributor Author

@dmirgaev dmirgaev Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this option on purpose as we are planning to enable tests for "material" theme in the nearest future

const dataGrid = new DataGrid('#container');

await t.expect(dataGrid.isReady()).ok();

// act
await dataGrid.scrollTo(t, { top: 500 });
await dataGrid.apiColumnOption('group', 'groupIndex', 0);
let visibleRows = await dataGrid.apiGetVisibleRows();

// assert
await t
.expect(visibleRows[0].rowType)
.eql('data')
.expect(visibleRows[0].key)
.notEql(1);

// act
await dataGrid.apiColumnOption('group', 'groupIndex', 0);
await t.expect(dataGrid.isReady()).ok();
visibleRows = await dataGrid.apiGetVisibleRows();

// assert
await t
.expect(visibleRows.length)
Expand All @@ -250,17 +261,16 @@ test.meta({ unstable: true })('Ungrouping after grouping should work correctly i

// act
await dataGrid.apiColumnOption('group', 'groupIndex', 'undefined');

// assert
await t.expect(dataGrid.isReady()).ok();
const groupRow = dataGrid.getGroupRowSelector();

// assert
await t
.expect(groupRow.exists)
.notOk();

visibleRows = await dataGrid.apiGetVisibleRows();

// assert
await t
.expect(visibleRows[0].rowType)
.eql('data')
Expand All @@ -279,8 +289,7 @@ test.meta({ unstable: true })('Ungrouping after grouping should work correctly i
return items;
};
return createWidget('dxDataGrid', {
height: 400,
loadingTimeout: null,
height: 500,
keyExpr: 'id',
dataSource: getItems(),
scrolling: {
Expand Down Expand Up @@ -494,13 +503,23 @@ test('Header container should have padding-right if grid has max-height and scro
});
});

test.meta({ unstable: true })('New virtual mode. A detail row should be rendered when the last master row is expanded', async (t) => {
test('New virtual mode. A detail row should be rendered when the last master row is expanded', async (t) => {
const ROWS_AMOUNT = 100;
const dataGrid = new DataGrid('#container');
const dataRowSelector = `.${ClassNames.dataRow}`;

const getFirstVisibleRowHeight = ClientFunction(() => $((window as any).widget.element())
.find(dataRowSelector)
.first()
.height() ?? 0, { dependencies: { dataRowSelector } });

await t.expect(dataGrid.isReady()).ok();

// act
await dataGrid.scrollTo(t, { top: 3300 });
const firstVisibleRowHeight = await getFirstVisibleRowHeight();
const scrollTopOffset = ROWS_AMOUNT * firstVisibleRowHeight;

await dataGrid.scrollTo(t, { top: scrollTopOffset });
await t
.wait(300)
.click(dataGrid.getDataRow(99).getCommandCell(0).element);
Expand All @@ -515,11 +534,11 @@ test.meta({ unstable: true })('New virtual mode. A detail row should be rendered
.expect(penultimateRow.rowType)
.eql('data')
.expect(penultimateRow.key)
.eql(100)
.eql(ROWS_AMOUNT)
.expect(lastRow.rowType)
.eql('detail')
.expect(lastRow.key)
.eql(100);
.eql(ROWS_AMOUNT);
}).before(async () => {
const getItems = (): Record<string, unknown>[] => {
const items: Record<string, unknown>[] = [];
Expand Down Expand Up @@ -548,11 +567,23 @@ test.meta({ unstable: true })('New virtual mode. A detail row should be rendered
});
});

test.meta({ unstable: true })('New virtual mode. An adaptive row should be rendered when the last row is expanded', async (t) => {
test('New virtual mode. An adaptive row should be rendered when the last row is expanded', async (t) => {
const ROWS_AMOUNT = 100;
const dataGrid = new DataGrid('#container');
const dataRowSelector = `.${ClassNames.dataRow}`;

const getFirstVisibleRowHeight = ClientFunction(() => $((window as any).widget.element())
.find(dataRowSelector)
.first()
.height() ?? 0, { dependencies: { dataRowSelector } });

await t.expect(dataGrid.isReady()).ok();

// act
await dataGrid.scrollTo(t, { top: 3300 });
const firstVisibleRowHeight = await getFirstVisibleRowHeight();
const scrollTopOffset = ROWS_AMOUNT * firstVisibleRowHeight;

await dataGrid.scrollTo(t, { top: scrollTopOffset });
await t
.wait(300)
.click(dataGrid.getDataRow(99).getCommandCell(3).element);
Expand All @@ -567,11 +598,11 @@ test.meta({ unstable: true })('New virtual mode. An adaptive row should be rende
.expect(penultimateRow.rowType)
.eql('data')
.expect(penultimateRow.key)
.eql(100)
.eql(ROWS_AMOUNT)
.expect(lastRow.rowType)
.eql('detailAdaptive')
.expect(lastRow.key)
.eql(100);
.eql(ROWS_AMOUNT);
}).before(async () => {
const getItems = (): Record<string, unknown>[] => {
const items: Record<string, unknown>[] = [];
Expand Down Expand Up @@ -604,11 +635,14 @@ test.meta({ unstable: true })('New virtual mode. An adaptive row should be rende
});
});

test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in view port', async (t) => {
// Theme dependent test
test.meta({ runInTheme: Themes.fluentBlue })('New virtual mode. Virtual rows should not be in view port', async (t) => {
Copy link
Contributor

@anna-shakhova anna-shakhova Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test.meta({ runInTheme: Themes.fluentBlue })('New virtual mode. Virtual rows should not be in view port', async (t) => {
test('New virtual mode. Virtual rows should not be in view port', async (t) => {

const dataGrid = new DataGrid('#container');
const virtualRowSelector = `.${ClassNames.virtualRow}`;
const dataRowSelector = `.${ClassNames.dataRow}`;
const getVirtualRowInfo = ClientFunction(() => {
const result: any = {};
const $virtualRows = $((window as any).widget.element()).find(CLASS.virtualRow);
const $virtualRows = $((window as any).widget.element()).find(virtualRowSelector);

result.count = $virtualRows.length;
$virtualRows.each((index, el) => {
Expand All @@ -620,17 +654,17 @@ test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in v
});

return result;
});
}, { dependencies: { virtualRowSelector } });
const getVisibleRowsHeight = ClientFunction(() => {
let result = 0;
const $rows = $((window as any).widget.element()).find(CLASS.dataRow);
const $rows = $((window as any).widget.element()).find(dataRowSelector);

$rows.each((_, el) => {
result += $(el).height() ?? 0;
});

return result;
});
}, { dependencies: { dataRowSelector } });

await t.wait(350);
let visibleRows = await dataGrid.apiGetVisibleRows();
Expand All @@ -640,16 +674,16 @@ test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in v
// assert
await t
.expect(visibleRows.length)
.eql(20)
.eql(16)
.expect(virtualRowInfo.count)
.eql(1)
.expect(virtualRowInfo[0].top >= visibleRowsHeight)
.ok();

// act
await dataGrid.scrollTo(t, { top: 1580 });
await dataGrid.scrollTo(t, { top: 2520 });
await t.wait(300);
await dataGrid.scrollTo(t, { top: 3250 });
await dataGrid.scrollTo(t, { top: 4580 });
await t.wait(600);

visibleRows = await dataGrid.apiGetVisibleRows();
Expand All @@ -662,16 +696,16 @@ test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in v
// assert
await t
.expect(visibleRows.length)
.eql(10)
.eql(8)
.expect(visibleRows[0].key)
.eql(91)
.eql(93)
.expect(virtualRowInfo.count)
.eql(1)
.expect(bottomVirtualRowPosition <= topScrollPosition)
.ok();

// act
await dataGrid.scrollTo(t, { top: 1580 });
await dataGrid.scrollTo(t, { top: 2520 });
await t.wait(300);
await dataGrid.scrollTo(t, { top: 0 });
await t.wait(300);
Expand All @@ -683,7 +717,7 @@ test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in v
// assert
await t
.expect(visibleRows.length)
.eql(10)
.eql(8)
.expect(visibleRows[0].key)
.eql(1)
.expect(virtualRowInfo.count)
Expand Down Expand Up @@ -727,7 +761,7 @@ test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in v
return (window as any).myStore.totalCount(loadOptions);
},
} as any, // todo check
height: 300,
height: 420,
remoteOperations: true,
scrolling: {
mode: 'virtual',
Expand Down Expand Up @@ -883,7 +917,8 @@ test.meta({ browserSize: [800, 700] })('New mode. Rows should be rendered proper
});
});

test.meta({ unstable: true, browserSize: [800, 800] })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => {
// Theme dependent test
test.meta({ browserSize: [800, 800], runInTheme: Themes.fluentBlue })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => {
Copy link
Contributor

@anna-shakhova anna-shakhova Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test.meta({ browserSize: [800, 800], runInTheme: Themes.fluentBlue })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => {
test.meta({ browserSize: [800, 800])('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => {

const dataGrid = new DataGrid('#container');

await t.expect(dataGrid.isReady()).ok();
Expand All @@ -910,23 +945,23 @@ test.meta({ unstable: true, browserSize: [800, 800] })('Rows are rendered proper
.ok();

// act
await scrollWindowTo(3000);
await scrollWindowTo(3100);

// assert
await t
.expect(getWindowScrollPosition())
.eql(3000)
.eql(3100)
.wait(300);

visibleRows = await dataGrid.apiGetVisibleRows();

// assert
await t
.expect(visibleRows.length)
.eql(26)
.expect(visibleRows[0].key > 30)
.eql(19)
.expect(visibleRows[0].key > 20)
.ok()
.expect(visibleRows[25].key > 55)
.expect(visibleRows[18].key > 35)
.ok();

// act
Expand All @@ -938,23 +973,23 @@ test.meta({ unstable: true, browserSize: [800, 800] })('Rows are rendered proper
.eql(6000);

// act
await scrollWindowTo(3000);
await scrollWindowTo(3100);

// assert
await t
.expect(getWindowScrollPosition())
.eql(3000)
.eql(3100)
.wait(300);

visibleRows = await dataGrid.apiGetVisibleRows();

// assert
await t
.expect(visibleRows.length)
.eql(26)
.expect(visibleRows[0].key > 30)
.eql(19)
.expect(visibleRows[0].key > 20)
.ok()
.expect(visibleRows[25].key > 55)
.expect(visibleRows[18].key > 35)
.ok();

// act
Expand Down
Loading