DataGrid - TestCafe tests - Scrolling: Fix skipped tests#32361
Merged
dmirgaev merged 12 commits intoDevExpress:26_1from Feb 4, 2026
Merged
DataGrid - TestCafe tests - Scrolling: Fix skipped tests#32361dmirgaev merged 12 commits intoDevExpress:26_1from
dmirgaev merged 12 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes 6 previously unstable TestCafe tests in the DataGrid scrolling test suite by removing the unstable: true meta flag. The tests cover various virtual scrolling scenarios including grouping, master-detail, adaptive rows, and window scrolling.
Changes:
- Removed
unstable: trueflag from 6 DataGrid scrolling tests - Tests now marked as stable and will run consistently in CI
- No changes to test logic or implementation
dmirgaev
force-pushed
the
26_1__scrolling_skipped_test
branch
from
879a09b to
27c3316
Compare
|
|
||
| test.meta({ unstable: true })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => { | ||
| // Theme dependent test | ||
| test.meta({ runInTheme: Themes.fluentBlue })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test.meta({ runInTheme: Themes.fluentBlue })('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => { | |
| test('Ungrouping after grouping should work correctly if row rendering mode is virtual', async (t) => { |
there is no need in runInTheme meta - by default tests run only in fluent.blue theme
we use this flag if we do not want test to be run in fluent theme and instead run it in some other theme
Contributor
Author
There was a problem hiding this comment.
I added this option on purpose as we are planning to enable tests for "material" theme in the nearest future
|
|
||
| test.meta({ unstable: true })('New virtual mode. Virtual rows should not be in view port', async (t) => { | ||
| // Theme dependent test | ||
| test.meta({ runInTheme: Themes.fluentBlue })('New virtual mode. Virtual rows should not be in view port', async (t) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test.meta({ runInTheme: Themes.fluentBlue })('New virtual mode. Virtual rows should not be in view port', async (t) => { | |
| test('New virtual mode. Virtual rows should not be in view port', async (t) => { |
|
|
||
| test.meta({ unstable: true, browserSize: [800, 800] })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => { | ||
| // Theme dependent test | ||
| test.meta({ browserSize: [800, 800], runInTheme: Themes.fluentBlue })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test.meta({ browserSize: [800, 800], runInTheme: Themes.fluentBlue })('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => { | |
| test.meta({ browserSize: [800, 800])('Rows are rendered properly when window content is scrolled (T1070388)', async (t) => { |
anna-shakhova
approved these changes
Feb 4, 2026
dmirgaev
added a commit
to dmirgaev/DevExtreme
that referenced
this pull request
Feb 4, 2026
dmirgaev
added a commit
to dmirgaev/DevExtreme
that referenced
this pull request
Feb 4, 2026
dmirgaev
added a commit
that referenced
this pull request
Feb 4, 2026
dmirgaev
added a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.