Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves TypeScript type definitions throughout the DateBox component and related modules, removing @ts-expect-error comments and adding proper type annotations. The changes focus on:
Changes:
- Enhanced type definitions for DateBox core classes and strategies with proper interfaces and type annotations
- Improved type safety for date manipulation utilities and mask handling
- Removed numerous
@ts-expect-errorsuppressions by fixing underlying type issues - Updated
dxElementWrapperinterface to support additional parameter types (string,dxElementWrapper) - Enhanced DateLocalization interface with missing methods (
formatUsesDayName,formatUsesMonthName,parse)
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/core/renderer.d.ts |
Added support for string and dxElementWrapper types in add() and append() methods |
packages/devextreme/js/common/core/localization/date.d.ts |
Added missing methods and improved parameter types for DateLocalization interface |
packages/devextreme/js/__internal/ui/scroll_view/scrollable.ts |
Added event parameter to onStart/onEnd/onBounce handlers |
packages/devextreme/js/__internal/ui/menu/menu.ts |
Removed ts-expect-error by fixing dxElementWrapper.add() types |
packages/devextreme/js/__internal/ui/diagram/ui.diagram.menu_helper.ts |
Replaced property access with optional chaining and removed ts-expect-errors |
packages/devextreme/js/__internal/ui/date_box/m_date_view_roller.ts |
Comprehensive type improvements with proper interfaces and generics |
packages/devextreme/js/__internal/ui/date_box/m_date_utils.ts |
Added type definitions for format keys, date components, and utility functions |
packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy*.ts |
Enhanced strategy classes with proper types and removed ts-expect-errors |
packages/devextreme/js/__internal/ui/date_box/m_date_box.mask*.ts |
Improved mask handling with explicit types for date parts and validation |
packages/devextreme/js/__internal/ui/date_box/m_date_box.base.ts |
Renamed dateOption to getDateOption/setDateOption with proper typing |
packages/devextreme/js/__internal/ui/date_box/date_view.ts |
Removed TODO comments and added proper event types |
packages/devextreme/js/__internal/ui/calendar/calendar.views.ts |
Removed unnecessary eslint-disable comments |
packages/devextreme/js/__internal/grids/grid_core/** |
Removed ts-expect-error suppressions |
packages/devextreme/js/__internal/events/m_visibility_change.ts |
Removed ts-expect-error for dxElementWrapper.add() |
packages/devextreme/js/__internal/core/localization/date.ts |
Made format parameter optional in parse() method |
packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.calendar.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/date_box/m_date_box.mask.ts
Outdated
Show resolved
Hide resolved
marker-dao
reviewed
Feb 4, 2026
packages/devextreme/js/__internal/ui/date_box/m_date_box.mask.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/date_box/m_date_box.mask.ts
Outdated
Show resolved
Hide resolved
r-farkhutdinov
approved these changes
Feb 4, 2026
marker-dao
approved these changes
Feb 4, 2026
pharret31
reviewed
Feb 4, 2026
dmirgaev
approved these changes
Feb 4, 2026
EugeniyKiyashko
approved these changes
Feb 4, 2026
EugeniyKiyashko
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.