Skip to content

TextEditor ClearButton and Label: Remove m_#32546

Merged
marker-dao merged 2 commits into
DevExpress:26_1from
marker-dao:26_1_texteditor_clear_label_remove_m
Feb 12, 2026
Merged

TextEditor ClearButton and Label: Remove m_#32546
marker-dao merged 2 commits into
DevExpress:26_1from
marker-dao:26_1_texteditor_clear_label_remove_m

Conversation

@marker-dao

Copy link
Copy Markdown
Contributor

No description provided.

@marker-dao marker-dao self-assigned this Feb 12, 2026
@marker-dao marker-dao marked this pull request as ready for review February 12, 2026 15:11
@marker-dao marker-dao requested a review from a team as a code owner February 12, 2026 15:11
Copilot AI review requested due to automatic review settings February 12, 2026 15:11
r-farkhutdinov
r-farkhutdinov previously approved these changes Feb 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DevExtreme’s internal TextEditor “label” and “clear button” module naming to remove the m_ prefix, aligning imports across the core implementation and QUnit tests.

Changes:

  • Updated editor-related tests to import TextEditorLabel from __internal/ui/text_box/text_editor.label.
  • Added the new internal implementation file text_editor.label.ts and switched m_text_editor.base.ts to consume it.
  • Updated ClearButton imports to text_editor.clear (including m_date_range_box.ts).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textbox.tests.js Updates TextEditorLabel import path to new module name.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textEditorParts/common.tests.js Updates TextEditorLabel import path to new module name.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textEditorLabel.tests.js Updates TextEditorLabel import path to new module name.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/tagBox.tests.js Updates TextEditorLabel import path to new module name.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js Updates TextEditorLabel import path to new module name.
packages/devextreme/js/__internal/ui/text_box/text_editor.label.ts Introduces the renamed TextEditorLabel implementation.
packages/devextreme/js/__internal/ui/text_box/text_editor.clear.ts Removes an eslint suppression comment near _legacyRender.
packages/devextreme/js/__internal/ui/text_box/m_text_editor.base.ts Switches imports to text_editor.clear and text_editor.label.
packages/devextreme/js/__internal/ui/date_range_box/m_date_range_box.ts Switches ClearButton import to text_editor.clear.
Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/ui/text_box/text_editor.clear.ts:67

  • _legacyRender does not use this, and this file previously had a class-methods-use-this eslint suppression. Removing it will likely reintroduce a lint failure (the repo still uses this suppression pattern in multiple TextBox/TextEditor classes). Either re-add the eslint-disable for this method, or refactor _legacyRender into a static/helper function so it no longer triggers the rule.

@marker-dao marker-dao merged commit dde961c into DevExpress:26_1 Feb 12, 2026
118 of 119 checks passed
@marker-dao marker-dao deleted the 26_1_texteditor_clear_label_remove_m branch February 12, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants