TextEditor ClearButton and Label: Remove m_#32546
Merged
marker-dao merged 2 commits intoFeb 12, 2026
Merged
Conversation
r-farkhutdinov
previously approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DevExtreme’s internal TextEditor “label” and “clear button” module naming to remove the m_ prefix, aligning imports across the core implementation and QUnit tests.
Changes:
- Updated editor-related tests to import
TextEditorLabelfrom__internal/ui/text_box/text_editor.label. - Added the new internal implementation file
text_editor.label.tsand switchedm_text_editor.base.tsto consume it. - Updated
ClearButtonimports totext_editor.clear(includingm_date_range_box.ts).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textbox.tests.js | Updates TextEditorLabel import path to new module name. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textEditorParts/common.tests.js | Updates TextEditorLabel import path to new module name. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/textEditorLabel.tests.js | Updates TextEditorLabel import path to new module name. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/tagBox.tests.js | Updates TextEditorLabel import path to new module name. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js | Updates TextEditorLabel import path to new module name. |
| packages/devextreme/js/__internal/ui/text_box/text_editor.label.ts | Introduces the renamed TextEditorLabel implementation. |
| packages/devextreme/js/__internal/ui/text_box/text_editor.clear.ts | Removes an eslint suppression comment near _legacyRender. |
| packages/devextreme/js/__internal/ui/text_box/m_text_editor.base.ts | Switches imports to text_editor.clear and text_editor.label. |
| packages/devextreme/js/__internal/ui/date_range_box/m_date_range_box.ts | Switches ClearButton import to text_editor.clear. |
Comments suppressed due to low confidence (1)
packages/devextreme/js/__internal/ui/text_box/text_editor.clear.ts:67
_legacyRenderdoes not usethis, and this file previously had aclass-methods-use-thiseslint suppression. Removing it will likely reintroduce a lint failure (the repo still uses this suppression pattern in multiple TextBox/TextEditor classes). Either re-add the eslint-disable for this method, or refactor_legacyRenderinto a static/helper function so it no longer triggers the rule.
727c7dd to
b4b8f49
Compare
r-farkhutdinov
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.