TextBox Utils: Improve typing#32550
Merged
Merged
Conversation
r-farkhutdinov
previously approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TypeScript typing for TextBox utility functions by adding explicit type annotations and better ts-expect-error comments. The changes focus on two utility files that handle scrolling and caret positioning.
Changes:
- Added explicit TypeScript types to
allowScrollandprepareScrollDatafunctions, including parameter types and return types - Introduced
TextBoxScrollDatainterface to better define the return type ofprepareScrollData - Improved ts-expect-error comments to be more descriptive about what needs to be fixed in type definitions
- Simplified destructuring in m_utils.caret.ts while maintaining the same ts-expect-error documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/text_box/m_utils.scroll.ts | Added type annotations, interface definition, and improved ts-expect-error comments for scroll utility functions |
| packages/devextreme/js/__internal/ui/text_box/m_utils.caret.ts | Simplified destructuring and improved ts-expect-error comment for mac property |
marker-dao
force-pushed
the
26_1_textbox_utils
branch
from
350a398 to
fbfac75
Compare
Zedwag
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.