Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses eslint issues in demo applications by fixing two types of violations:
- Vue component props: Making props optional to align with TypeScript and Vue best practices
- Angular error handling: Changing throw statements to use Error objects instead of string literals
- Code formatting: Fixing spacing in type annotations
Changes:
- Made Vue component props optional (adding
?suffix) while ensuring default values are provided viawithDefaults() - Updated Angular error handlers to throw Error objects (
throw new Error(...)) instead of string literals (throw '...') - Fixed spacing in a TypeScript type annotation
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Toast/Overview/Vue/ProductItem.vue | Made product prop optional with default value |
| apps/demos/Demos/Stepper/FormIntegration/Vue/RoomMealPlanTemplate.vue | Made formData prop optional with default value |
| apps/demos/Demos/Stepper/FormIntegration/Vue/GuestsTemplate.vue | Made formData prop optional with default value |
| apps/demos/Demos/Stepper/FormIntegration/Vue/DatesTemplate.vue | Made formData prop optional with default value |
| apps/demos/Demos/Stepper/FormIntegration/Vue/ConfirmationTemplate.vue | Made formData and isConfirmed props optional with default values |
| apps/demos/Demos/Stepper/FormIntegration/Vue/AdditionalTemplate.vue | Made formData prop optional with default value |
| apps/demos/Demos/Diagram/UICustomization/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/ReadOnly/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/Overview/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/CustomShapesWithTexts/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Vue/CustomShapeTemplate.vue | Made employee, editEmployee, and deleteEmployee props optional with default values |
| apps/demos/Demos/Diagram/CustomShapesWithTemplates/Vue/CustomShapeTemplate.vue | Made employee and showInfo props optional with default values |
| apps/demos/Demos/Diagram/CustomShapesWithIcons/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/Containers/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Diagram/Adaptability/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Charts/SignalRService/Vue/TooltipTemplate.vue | Made pointInfo prop optional with default value |
| apps/demos/Demos/Charts/Colorization/Angular/app/app.component.ts | Fixed spacing in type annotation (removed extra space) |
| apps/demos/Demos/Charts/ClientSideDataProcessing/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Charts/BarSparklines/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
| apps/demos/Demos/Autocomplete/Overview/Angular/app/app.component.ts | Changed error handler to throw Error object instead of string literal |
dmlvr
approved these changes
Feb 13, 2026
r-farkhutdinov
approved these changes
Feb 13, 2026
marker-dao
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.