Scheduler — Replace underscore-prefixed: Scheduler core (m_scheduler, m_recurrence_editor)#32811
Merged
aleksei-semikozov merged 7 commits intoDevExpress:26_1from Mar 6, 2026
Conversation
…th private access modifiers
…scheduler.ts - _appointmentPopup → appointmentPopup - _appointmentTooltip → appointmentTooltip - _workSpaceRecalculation → workSpaceRecalculation - _header → header - _reloadDataSource → reloadDataSource - _refreshWorkSpace → refreshWorkSpace - _setRemoteFilterIfNeeded → setRemoteFilterIfNeeded - _renderWorkSpace → renderWorkSpace
.../devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.dateNavigator.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.options.tests.js
Show resolved
Hide resolved
…enames - helpers.js: _appointmentPopup → appointmentPopup - integration.dateNavigator.tests.js: update assert message for setRemoteFilterIfNeeded - common.options.tests.js: update assert message for reloadDataSource
…ests - common.methods.tests.js: _editAppointmentData → editAppointmentData - common.options.tests.js: _createAppointmentPopupForm → createAppointmentPopupForm
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.options.tests.js
Show resolved
Hide resolved
Contributor
|
Can we rename method _getAppointmentTemplate in m_scheduler.ts file? |
Contributor
|
Can we rename _checkRecurringAppointment in m_scheduler.ts file? |
Contributor
|
Can we rename _updateAppointment in scheduler.ts? |
Contributor
|
Can we rename _getUpdatedData in scheduler.ts ? |
Contributor
|
Can we rename _isScrollOptionsObject in scheduler.ts? |
This was referenced Mar 6, 2026
…ngAppointment - m_scheduler.ts: _getAppointmentTemplate → getAppointmentTemplate - m_scheduler.ts: _checkRecurringAppointment → checkRecurringAppointment - m_compact_appointments_helper.ts: update instance call - integration.appointmentCollector.tests.js: update mock method name - m_subscribes.ts: update 2 calls to checkRecurringAppointment
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.options.tests.js
Show resolved
Hide resolved
sjbur
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.