Scheduler — fix scrollTo method ignores single property alignInView#32886
Merged
aleksei-semikozov merged 3 commits intoDevExpress:26_1from Mar 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes dxScheduler.scrollTo so that passing an options object with only alignInView is recognized correctly (instead of being treated as deprecated positional arguments), and adds Jest coverage for the behavior.
Changes:
- Updated
scrollTodeprecation warning text and adjusted options-object detection to look foralignInView. - Added/expanded Jest tests for
scrollTo(deprecation warning path andalignInViewaffecting horizontal scroll position).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/m_scheduler.ts |
Fixes options-object detection for scrollTo and updates the deprecation warning message. |
packages/devextreme/js/__internal/scheduler/__tests__/scheduler.test.ts |
Adds Jest coverage for scrollTo warning behavior and verifies differing scroll offsets for alignInView: 'start' vs 'center'. |
You can also share your feedback on Copilot code review. Take the survey.
sjbur
approved these changes
Mar 12, 2026
aleksei-semikozov
deleted the
fix/scheduler-scroll-to-align-in-view-detection_26_1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.