Scheduler — Add ESLint naming-convention rule to forbid underscore-prefixed members by aleksei-semikozov · Pull Request #33126 · DevExpress/DevExtreme

aleksei-semikozov · 2026-04-02T00:57:01Z

No description provided.

…efixed members

Copilot

Pull request overview

This PR tightens linting for the internal Scheduler TypeScript code by forbidding underscore-prefixed member names, while allowing a curated set of legacy/override members to keep existing code compliant.

Changes:

Add a Scheduler-specific allowlist and regex to exempt known legacy/override underscore members from the naming-convention rule.
Change @typescript-eslint/naming-convention for Scheduler to forbid underscore-prefixed memberLike identifiers by default.
Add a temporary override to still allow underscore-prefixed members under js/__internal/scheduler/appointments/** pending refactoring.

packages/devextreme/eslint.config.mjs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

packages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_day.ts

packages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_week.ts

.../devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_work_week.ts

...xtreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_timeline_month.ts

...ages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_month.ts

packages/devextreme/js/__internal/scheduler/workspaces/helpers/m_position_helper.ts

…iers

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

packages/devextreme/eslint-scheduler-allowlist.mjs

…ndex

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/scheduler/workspaces/helpers/m_position_helper.ts:243

getMaxAllowedVerticalPosition appears to be an internal helper (previously underscore-prefixed) and is only used inside these strategy classes. Consider making it protected (or private) to preserve encapsulation and prevent other code from depending on it as a public method.

  getMaxAllowedVerticalPosition({
    groupIndex,
    showAllDayPanel,
    isGroupedAllDayPanel,
  }) {
    const { rowIndex } = this.viewDataProvider.getLastGroupCellPosition(groupIndex);

...ages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_month.ts

packages/devextreme/eslint-scheduler-allowlist.mjs

…ents

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

packages/devextreme/eslint-scheduler-allowlist.mjs

… _dataSourceLoadedCallback

…n to Widget overrides

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

…s (broke QUnit tests)

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

…d to overrides

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

packages/devextreme/eslint.config.mjs

… TODO

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/scheduler/shaders/current_time_shader.ts

…efixed members (DevExpress#33126)

Scheduler - Add ESLint naming-convention rule to forbid underscore-pr…

d2d91d7

…efixed members

aleksei-semikozov added the 26_1 label Apr 2, 2026

aleksei-semikozov self-assigned this Apr 2, 2026

Scheduler - Add legacy members to naming-convention allowlist

d3a8e3c

aleksei-semikozov force-pushed the eslint-naming-convention branch from 2b90428 to d3a8e3c Compare April 2, 2026 03:13

aleksei-semikozov marked this pull request as ready for review April 2, 2026 09:56

Copilot AI review requested due to automatic review settings April 2, 2026 09:57

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 09:57 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

packages/devextreme/eslint.config.mjs Outdated Show resolved Hide resolved

packages/devextreme/eslint.config.mjs Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 07:57

Scheduler - Replace underscore-prefixed with private/protected modifiers

4b12af6

Scheduler - Remove renamed methods from ESLint allowlist

d47eb48

aleksei-semikozov requested a review from a team as a code owner April 2, 2026 10:58

Scheduler - Extract ESLint allowlist to separate file

0e98856

Copilot AI review requested due to automatic review settings April 2, 2026 11:28

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 11:29 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

aleksei-semikozov added 2 commits April 2, 2026 09:35

Scheduler - Replace underscore-prefixed members in shaders with modif…

35f9a1e

…iers

Scheduler - Restore _shader to allowlist (used in m_work_space.ts)

ef97b50

Copilot AI review requested due to automatic review settings April 2, 2026 12:54

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 12:55 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

packages/devextreme/eslint-scheduler-allowlist.mjs Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 10:08

Scheduler - Replace _calculateCellIndex with protected calculateCellI…

8d9569b

…ndex

Scheduler - Replace underscore-prefixed in m_position_helper and m_form

e782ffe

Copilot AI review requested due to automatic review settings April 2, 2026 13:11

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 13:11 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

...ages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator_month.ts Outdated Show resolved Hide resolved

packages/devextreme/eslint-scheduler-allowlist.mjs Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 17:09

Scheduler - Replace underscore-prefixed members in header

597938c

Scheduler - Replace underscore-prefixed in calendar, popup, r1 compon…

974db2b

…ents

Copilot AI review requested due to automatic review settings April 2, 2026 20:16

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 20:16 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

packages/devextreme/js/__internal/scheduler/m_scheduler.ts Outdated Show resolved Hide resolved

packages/devextreme/js/__internal/scheduler/m_scheduler.ts Show resolved Hide resolved

packages/devextreme/eslint-scheduler-allowlist.mjs Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 19:44

Scheduler - Revert _dataSource rename (inherited from Widget) and fix…

947e2b8

… _dataSourceLoadedCallback

Scheduler - Move _dataSource, _dataSourceLoadedCallback, _createActio…

28e5bff

…n to Widget overrides

Copilot AI review requested due to automatic review settings April 2, 2026 22:47

Copilot started reviewing on behalf of aleksei-semikozov April 2, 2026 22:47 View session

Scheduler - Move _options to Widget overrides

03256f0

Copilot AI reviewed Apr 2, 2026

View reviewed changes

packages/devextreme/js/__internal/scheduler/m_scheduler.ts Show resolved Hide resolved

packages/devextreme/js/__internal/scheduler/m_scheduler.ts Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 19:55

Scheduler - Fix remaining _dataSourceChangedHandler reference

f53a6f0

Scheduler - Revert header, calendar, popup, r1, m_scheduler.ts rename…

67a96e2

…s (broke QUnit tests)

Copilot AI review requested due to automatic review settings April 3, 2026 00:22

Copilot started reviewing on behalf of aleksei-semikozov April 3, 2026 00:23 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

aleksei-semikozov added 6 commits April 2, 2026 21:28

Scheduler - Replace underscore-prefixed members in header

36b1564

Scheduler - Replace underscore-prefixed members in m_calendar

b106c15

Scheduler - Replace underscore-prefixed in popup/form

69dfa98

Scheduler - Replace underscore-prefixed in r1 components

d159e26

Scheduler - Rename internal m_scheduler members, move Widget-inherite…

03ce643

…d to overrides

Scheduler - Add TODO comments to legacy allowlist members

a4f0129

Copilot AI review requested due to automatic review settings April 3, 2026 01:51

Copilot started reviewing on behalf of aleksei-semikozov April 3, 2026 01:52 View session

Scheduler - Merge workspace overrides into legacy, group by source file

09915c4

Copilot AI reviewed Apr 3, 2026

View reviewed changes

packages/devextreme/eslint.config.mjs Show resolved Hide resolved

aleksei-semikozov added 2 commits April 2, 2026 23:13

Scheduler - Add protected modifier to renamed overrides

2fba25b

Scheduler - Revert _getIntervalDuration rename, add to allowlist with…

857e020

… TODO

Copilot AI review requested due to automatic review settings April 3, 2026 02:16

Copilot started reviewing on behalf of aleksei-semikozov April 3, 2026 02:17 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

packages/devextreme/js/__internal/scheduler/shaders/current_time_shader.ts Show resolved Hide resolved

Tucchhaa approved these changes Apr 3, 2026

View reviewed changes

aleksei-semikozov merged commit b972d91 into DevExpress:26_1 Apr 3, 2026
107 of 108 checks passed

aleksei-semikozov added a commit to aleksei-semikozov/DevExtreme that referenced this pull request Apr 3, 2026

Scheduler — Add ESLint naming-convention rule to forbid underscore-pr…

eba42b0

…efixed members (DevExpress#33126)

Conversation

aleksei-semikozov commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants