DateBox: Update time list items when value is changed while popup is closed (T1325614)#33153
Merged
marker-dao merged 1 commit intoDevExpress:26_1from Apr 3, 2026
Merged
Conversation
marker-dao
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes DateBox’s pickerType: 'list' time strategy so that the time list’s underlying items are refreshed when value changes while the popup is closed, preventing stale date parts from being used on subsequent time selection.
Changes:
- Updated the internal DateBox list strategy to refresh list items on
renderValue()even when the popup is closed, while only updating selection/scroll when opened. - Added integration tests covering (1) preserving the updated date part after reopening and selecting a time and (2) refreshing list items after external value change while closed.
- Adjusted an existing serialized-date test to re-query list items after reopening.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.integration.tests.js | Adds regression coverage for refreshing list items after closed-popup value changes and updates an existing test to avoid stale DOM references. |
| packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.list.ts | Ensures list items are refreshed on value render even when closed; limits selection/scroll updates to the opened state. |
r-farkhutdinov
approved these changes
Apr 3, 2026
sjbur
pushed a commit
to sjbur/DevExtreme
that referenced
this pull request
May 5, 2026
…closed (T1325614) (DevExpress#33153) Co-authored-by: marker dao ® <youdontknow@marker-dao.eth>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.