Scheduler — Replace underscore-prefixed: Cherry-pick to 25_1 and validate completion#33164
Conversation
…eline, month, indicator) (DevExpress#32938)
aleksei-semikozov
force-pushed
the
cherry-pick/scheduler-underscore-final-25_1
branch
from
e5dcf29 to
5ee9e58
Compare
aleksei-semikozov
force-pushed
the
cherry-pick/scheduler-underscore-final-25_1
branch
from
c5053ee to
8fc6af8
Compare
…gies, view_model, cells) (DevExpress#32988)
| this.calendar?.option('value', date); | ||
| } | ||
|
|
||
| public _updateCurrentDate(date: Date): void { |
There was a problem hiding this comment.
This method still has underscore, as well as some other methods in this file. Was it omitted on purpose? In 26.2 it seems that, it doesn't have:
I don't want to check if all of the methods still have or not the underscores, because it would be just too much work for the branch that will stop being maintained in several months.
So I suggest to rename methods in this class, but only if it won't take a lot of your time
There was a problem hiding this comment.
Renamed to updateCurrentDate and updated the call site in m_date_navigator.ts.
There was a problem hiding this comment.
Same as here: #33164 (comment)
The 26.1 doesn't have _ here:
There was a problem hiding this comment.
Kept as _calculateCellIndex
There was a problem hiding this comment.
There was a problem hiding this comment.
Renamed to getCalendarOptions.
…nd view_data_generator files
…eRecurrenceOptions
…tegy base after rename
… + isDeletingAllowed)
…el keyboard handler was removed
2 participants
No description provided.