Scheduler — Add hiddenDays option to hide arbitrary days of the week by aleksei-semikozov · Pull Request #33188 · DevExpress/DevExtreme

aleksei-semikozov · 2026-04-07T12:03:27Z

No description provided.

… regen

…s-bundle regen" This reverts commit fbeace8.

This reverts commit 2467600.

…us hiddenWeekDays

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

sjbur · 2026-04-15T12:30:22Z

Day view Bug

  $('#scheduler').dxScheduler({
    timeZone: 'America/Los_Angeles',
    dataSource: data,
    views: ['day', 'week', 'workWeek', 'month', {
      type: 'day',
      name: 'myday',
      intervalCount: 7,
    }],
    hiddenWeekDays: [0, 1, 2, 3, 4, 5],
    currentView: 'myday',
    currentDate: new Date(2021, 3, 29),
    startDayHour: 9,
    height: 730,
  });

Actual result: all week days are visible

Expected result: hidden week days shouldn't be visible

Looks like we forgot about this case during the spec writing 😔

I think during chat with the PM the feature support for day view was more like 'nice to have' rather than 'must have'. But I looked at the code and it was rather easy to implement it. I tested, works fine. Added necessary tests.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

…te function

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Tucchhaa · 2026-04-16T11:15:19Z

+      case 'skippedDays':
+        break;


how this option can be changed? Public option name is hiddenWeekDays

…s.ts

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Tucchhaa · 2026-04-16T12:32:52Z

    switch (args.name) {
      case 'currentView':
      case 'views':
+      case 'hiddenWeekDays':


let's remove this, not relevant anymore

Tucchhaa · 2026-04-16T12:34:28Z

+      expect(getViews([input as RawViewType])).toEqual([{ ...output, skippedDays: [0, 6] }]);
+    });
+
+    describe('hiddenWeekDays', () => {


Is it possible to move tests in this describe group to normalize_hidden_days.test.ts?

Scheduler — Add hiddenDays option to hide arbitrary days of the week

0016a32

aleksei-semikozov added the 26_1 label Apr 7, 2026

aleksei-semikozov self-assigned this Apr 7, 2026

github-actions bot added the .d.ts label Apr 7, 2026

aleksei-semikozov and others added 26 commits April 8, 2026 13:01

Scheduler — Rename hiddenDays option to hiddenWeekDays per spec

2467600

Scheduler — Add hiddenWeekDays to scheduler.d.ts source for ts-bundle…

fbeace8

… regen

Revert "Scheduler — Add hiddenWeekDays to scheduler.d.ts source for t…

18943b8

…s-bundle regen" This reverts commit fbeace8.

Revert "Scheduler — Rename hiddenDays option to hiddenWeekDays per spec"

c385706

This reverts commit 2467600.

feat: rename hiddenDays to hiddenWeekDays and fix .d.ts

7cadb02

Merge branch '26_1' into feature/scheduler-hidden-days-impl-26_1

bbb309c

feat: add storybook

97f1fe8

refactor: fix typing

4904ffa

refactor: fix typing

a4b0767

feat: create helper for skipped days

f4ac369

fix: fix calculating hiddenDays for timeline

91d780d

fix: fix hiddenDays for timelineMonth

b1263af

refactor: optimize ts

2a11d14

fix: fix bug for view_generator for workWeek

19f3964

fix: fix test

d414219

refactor: remove useless typing

2ab9e9b

fix: fix hiddenWeekDays for workWeek

d9cedc5

refactor: revert SkippedDaysAnchorKind

da7160f

refactor: optimize

1bcb103

feat: allow hiddenWeekDays for agenda

2b82fa5

refactor: optimize

9c71b48

refactor: optimize

e32349a

feat: create type WeekdayIndex for skippedDays

b341ca6

feat: update agenda and header logic to support hiddenWeekDays

6a2a314

feat: change agenda logic to show only calendar dates in interval min…

9c81b76

…us hiddenWeekDays

fix: fix anchor day for workWeek

e30a7bd

Copilot AI review requested due to automatic review settings April 15, 2026 12:18

Copilot AI reviewed Apr 15, 2026

View reviewed changes

feat: add support for day and timelineday

1b666f2

fix: fix tests

1ed0d64

Copilot AI review requested due to automatic review settings April 15, 2026 12:39

Copilot AI reviewed Apr 15, 2026

View reviewed changes

sjbur added 3 commits April 15, 2026 15:13

refactor: unify week and workWeek date handling in getIntervalStartDa…

7313053

…te function

fix: remove skippedDays tests from workspace

e3f8d67

refactor: remove baseDaysInInterval

6a7a2b0

Copilot AI review requested due to automatic review settings April 16, 2026 08:58

Copilot AI reviewed Apr 16, 2026

View reviewed changes

sjbur added 2 commits April 16, 2026 11:45

feat: move skippedDays to getviewoption

0cffa6f

fix: fix tests

b15188c

Copilot AI review requested due to automatic review settings April 16, 2026 10:09

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Tucchhaa reviewed Apr 16, 2026

View reviewed changes

sjbur added 4 commits April 16, 2026 14:00

feat: remove internal skippedOptions and create normalize_skipped_day…

12f577d

…s.ts

test: return deleted tests

d55e2a9

refactor: rename file

163cb3c

test: fix test

78ea5c3

Copilot AI review requested due to automatic review settings April 16, 2026 12:13

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Tucchhaa reviewed Apr 16, 2026

View reviewed changes

refactor: apply review

ab97b15

sjbur requested a review from Tucchhaa April 16, 2026 13:03

Tucchhaa approved these changes Apr 16, 2026

View reviewed changes

sjbur merged commit 8f03909 into DevExpress:26_1 Apr 16, 2026
103 checks passed

aleksei-semikozov deleted the feature/scheduler-hidden-days-impl-26_1 branch April 16, 2026 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduler — Add hiddenDays option to hide arbitrary days of the week#33188

Scheduler — Add hiddenDays option to hide arbitrary days of the week#33188
sjbur merged 66 commits intoDevExpress:26_1from
aleksei-semikozov:feature/scheduler-hidden-days-impl-26_1

aleksei-semikozov commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

sjbur commented Apr 15, 2026

Day view Bug

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Tucchhaa Apr 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Tucchhaa Apr 16, 2026

Uh oh!

sjbur Apr 16, 2026

Uh oh!

Tucchhaa Apr 16, 2026 •

edited

Loading

Uh oh!

sjbur Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aleksei-semikozov commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sjbur commented Apr 15, 2026

Day view Bug

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

sjbur Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sjbur Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Tucchhaa Apr 16, 2026 •

edited

Loading