ScrollView: prevent unnecessary scrollbar at non-100% browser zoom (T1310288)#33291
Merged
EugeniyKiyashko merged 2 commits intoDevExpress:26_1from Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue in the internal ScrollView simulated scrolling implementation where browser zoom (non-100%) can introduce rounding artifacts that cause an unnecessary scrollbar to appear.
Changes:
- Added a utility (
getAdjustedBaseContainerSize) to compensate for ~1px rounding artifacts when zoom is detected. - Updated simulated scrollbar sizing logic to use the adjusted base container size.
- Added Jest unit tests covering the adjustment behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/scroll_view/utils/get_adjusted_base_container_size.ts |
Introduces the zoom/rounding-artifact adjustment helper used when computing base sizing for scrollbar visibility. |
packages/devextreme/js/__internal/ui/scroll_view/utils/get_adjusted_base_container_size.test.ts |
Adds Jest coverage for zoom vs non-zoom scenarios and 1px vs >1px deltas. |
packages/devextreme/js/__internal/ui/scroll_view/scrollable.simulated.ts |
Integrates the helper into _updateScrollbar() to prevent false-positive scrollbars at non-100% zoom. |
dmlvr
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.