Potential fix for code scanning alert no. 354: Incomplete string escaping or encoding#33384
Merged
aleksei-semikozov merged 1 commit into26_1from Apr 23, 2026
Merged
Potential fix for code scanning alert no. 354: Incomplete string escaping or encoding#33384aleksei-semikozov merged 1 commit into26_1from
aleksei-semikozov merged 1 commit into26_1from
Conversation
…ping or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Aleksei Semikozov <alwexy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses code scanning alert #354 (“Incomplete string escaping or encoding”) by fully escaping scheduler allowlist tokens before composing them into a regex used by ESLint naming convention filtering.
Changes:
- Replace
$-only escaping with standard “escape all regex metacharacters” logic when buildingschedulerMemberAllowlistRegex.
sjbur
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/DevExpress/DevExtreme/security/code-scanning/354
Use complete regex escaping for each allowlist token before joining into an alternation.
Best fix: replace the
$-only escape with a standard “escape all regex metacharacters” expression:s.replace(/\$/g, '\\$')s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')This preserves current behavior for existing names while correctly handling backslashes and all other regex-significant characters.
Edit only
packages/devextreme/eslint-scheduler-allowlist.mjsat the export constructingschedulerMemberAllowlistRegex(line region around 129–130). No new imports or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.