Chat Suggestions: Clean suggestions when there are no items#33467
Merged
marker-dao merged 1 commit intoApr 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the internal Chat “Suggestions” rendering behavior so that when items becomes empty the underlying ButtonGroup is disposed/cleaned instead of staying initialized with zero items, preventing leftover markup/classes.
Changes:
- Update
Suggestionslogic to treat “has options” as “has non-empty items” for initialization/updates. - Extend QUnit coverage to assert the
ButtonGroupis cleaned whenitems: []is applied viaupdateOptions. - Minor
package.jsonscript reordering (keepsdev:playgrounddefined once).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/suggestions.tests.js | Strengthens the items: [] update test to verify ButtonGroup cleanup (no leftover widget class). |
| packages/devextreme/package.json | Repositions dev:playground script entry (no functional change beyond script availability/organization). |
| packages/devextreme/js/__internal/ui/chat/suggestions.ts | Switches init/update gating from “any options” to “non-empty items”, so empty items trigger clean(). |
r-farkhutdinov
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.