Skip to content

Lookup: Fix loading state flaky test #33469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-farkhutdinov merged 3 commits into from
Apr 30, 2026
Merged

Lookup: Fix loading state flaky test #33469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4c122e
Lookup: Fix loading state flaky test
Apr 30, 2026
67e0d13
Lookup: Remove styles after test
Apr 30, 2026
6292f4c
Lookup: Replace class names with constants
Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions e2e/testcafe-devextreme/tests/editors/lookup/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,17 @@ import { isMaterial, isMaterialBased, testScreenshot } from '../../../helpers/th
import url from '../../../helpers/getPageUrl';
import { createWidget } from '../../../helpers/createWidget';
import {
appendElementTo, insertStylesheetRulesToPage, setStyleAttribute,
appendElementTo, insertStylesheetRulesToPage, removeStylesheetRulesFromPage, setStyleAttribute,
} from '../../../helpers/domUtils';

const LOOKUP_FIELD_CLASS = 'dx-lookup-field';
const OVERLAY_CLASS = 'dx-overlay-content';

const LOADINDICATOR_SEGMENT_CLASS = 'dx-loadindicator-segment';
const LOADINDICATOR_CONTENT_CLASS = 'dx-loadindicator-content';
const LOADINDICATOR_ICON_CLASS = 'dx-loadindicator-icon';
const LOADINDICATOR_SEGMENT_INNER_CLASS = 'dx-loadindicator-segment-inner';

const stylingModes = ['outlined', 'underlined', 'filled'];
const labelModes = ['static', 'floating', 'hidden', 'outside'];

Expand Down Expand Up @@ -98,7 +103,7 @@ test.meta({ browserSize: [300, 400] })('Check popup height with no found data op
.ok(compareResults.errorMessages());
}).before(async () => createWidget('dxLookup', { dataSource: [], searchEnabled: true }));

test.meta({ browserSize: [300, 400], unstable: true })('Check popup height in loading state', async (t) => {
test.meta({ browserSize: [300, 400] })('Check popup height in loading state', async (t) => {
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);

await t.click(Selector(`.${LOOKUP_FIELD_CLASS}`));
Expand All @@ -109,19 +114,30 @@ test.meta({ browserSize: [300, 400], unstable: true })('Check popup height in lo
await t
.expect(compareResults.isValid())
.ok(compareResults.errorMessages());
}).before(async () => createWidget('dxLookup', {
dataSource: {
load() {
return new Promise((resolve) => {
setTimeout(() => {
resolve([1, 2, 3]);
}, 5000);
});
}).before(async () => {
await insertStylesheetRulesToPage(`
.${LOADINDICATOR_SEGMENT_CLASS},
.${LOADINDICATOR_CONTENT_CLASS},
.${LOADINDICATOR_ICON_CLASS},
.${LOADINDICATOR_SEGMENT_INNER_CLASS} {
animation: none !important;
}
`);

return createWidget('dxLookup', {
dataSource: {
load() {
return new Promise((resolve) => {
setTimeout(() => {
resolve([1, 2, 3]);
}, 5000);
});
},
},
},
valueExpr: 'id',
displayExpr: 'text',
}));
valueExpr: 'id',
displayExpr: 'text',
});
}).after(async () => removeStylesheetRulesFromPage());

test('Lookup appearance', async (t) => {
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
Expand Down
Loading