Skip to content

VectorMap: support mixed geometry types in GeoJSON (T1327745)#33477

Merged
pharret31 merged 1 commit intoDevExpress:26_1from
pharret31:26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported
Apr 30, 2026
Merged

VectorMap: support mixed geometry types in GeoJSON (T1327745)#33477
pharret31 merged 1 commit intoDevExpress:26_1from
pharret31:26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported

Conversation

@pharret31
Copy link
Copy Markdown
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Apr 30, 2026
Copilot AI review requested due to automatic review settings April 30, 2026 12:45
@pharret31 pharret31 requested a review from a team as a code owner April 30, 2026 12:45
@pharret31 pharret31 added the 26_1 label Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VectorMap layer projection logic to correctly handle GeoJSON line layers that contain a mix of LineString and MultiLineString geometries (T1327745), preventing incorrect projection results when the first feature’s geometry differs from subsequent features.

Changes:

  • Reworked line projection selection to be adaptive per feature, using the feature’s GeoJSON geometry.type when available.
  • Adjusted/extended VectorMap QUnit tests to cover mixed LineString/MultiLineString GeoJSON feature collections.
  • Updated expectations for degenerate MultiLineString projection output to match the new adaptive behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/devextreme/testing/tests/DevExpress.viz.vectorMap/mapLayer_new.tests.js Adds coverage for mixed LineString/MultiLineString GeoJSON in line layers and updates degenerate output expectation.
packages/devextreme/testing/tests/DevExpress.viz.vectorMap/mapLayer.strategies.tests.js Updates strategy projection tests to pass explicit geometry type into the line projection logic.
packages/devextreme/js/__internal/viz/vector_map/map_layer.ts Implements per-element adaptive line projection and passes GeoJSON geometry.type into projection.

@pharret31 pharret31 force-pushed the 26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported branch from 6ff49ff to b87db0e Compare April 30, 2026 16:20
@pharret31 pharret31 merged commit 1cfd123 into DevExpress:26_1 Apr 30, 2026
166 of 171 checks passed
@pharret31 pharret31 deleted the 26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported branch April 30, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants