RadioGroup: Improve types#33488
Merged
r-farkhutdinov merged 2 commits intoMay 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TypeScript annotations around the internal RadioGroup implementation, its inner collection, and the standalone radio button so these legacy widgets align better with the monorepo's typed editor/collection infrastructure.
Changes:
- Adds explicit return/parameter types across the RadioGroup, RadioCollection, and RadioButton internals.
- Replaces several
extend(...)usages with object spread and documents multiple mixin-driven@ts-expect-errorcases. - Refactors a few option/handler paths to use typed locals and tuple-style forwarding.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/radio_group/m_radio_group.ts |
Main RadioGroup typing cleanup, option propagation updates, and internal handler refactors. |
packages/devextreme/js/__internal/ui/radio_group/m_radio_collection.ts |
Adds stronger typing for rendered item processing and keyboard handlers in the inner collection widget. |
packages/devextreme/js/__internal/ui/radio_group/m_radio_button.ts |
Adds explicit types for keyboard/click handling and checked-state rendering in the standalone radio button. |
r-farkhutdinov
force-pushed
the
26_1_radio_group_types
branch
from
1ac6bdb to
7ce4517
Compare
r-farkhutdinov
force-pushed
the
26_1_radio_group_types
branch
from
322302e to
5e0a5c7
Compare
Co-authored-by: Copilot <copilot@github.com>
r-farkhutdinov
force-pushed
the
26_1_radio_group_types
branch
from
5e0a5c7 to
308d3b3
Compare
marker-dao
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.