DataGrid - AI Assistant: Add processing to regenerate requests#33551
Merged
Alyar666 merged 3 commits intoMay 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DataGrid AI Assistant chat flow to support regenerating failed requests, aborting in-flight requests when the chat closes, and clearing the chat history by clearing the underlying message store.
Changes:
- Add abort handling for AI requests (including a dedicated “request stopped” message) and abort requests when the AI chat popup closes.
- Implement “regenerate” by re-sending the original prompt for an existing AI message and resetting that message back to the pending state.
- Add a
clear()API to the AI chat wrapper to clear the store and reload the chat datasource; update unit/integration tests accordingly.
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/localization/messages/ar.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/bg.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/ca.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/cs.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/da.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/de.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/el.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/en.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/es.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/fa.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/fi.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/fr.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/hu.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/it.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/ja.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/ko.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/lt.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/lv.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/nb.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/nl.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/pl.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/pt.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/ro.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/ru.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/sl.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/sv.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/tr.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/uk.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/vi.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/zh-tw.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/localization/messages/zh.json | Adds dxDataGrid-aiAssistantAbortMessage message key |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/utils.ts | Removes AI-author check helper and loosens hasCommandErrors input type |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/types.ts | Adds onClosed callback and changes onRegenerate to pass the AI message being regenerated |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts | Uses shared isAIMessage type guard, calls onClosed on popup hiding, and adds clear() to clear/reload the datasource |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts | Adds coverage for onClosed and clear(); removes coverage for removed isDisabled() API |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts | Introduces isAIMessage type guard for distinguishing assistant messages |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts | Adds AIMessage and AIAssistantRequestCallbacks (supports onAbort) |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Wires clear/close/regenerate handlers; consolidates request execution logic |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts | Adds onAbort propagation and adjusts completion handling to avoid triggering abort on normal completion |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts | Adds processing guard, supports regenerate by resetting message to pending, and fails pending message on abort |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/utils.test.ts | Adds unit tests for isAIMessage |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.test.ts | Adds tests for clear/close/regenerate behaviors and disabled toggling around requests |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view_controller.integration.test.ts | Adds integration tests for clear, abort-on-close, and regenerate flows |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts | Adds integration tests for onAbort callback behavior |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_controller.test.ts | Adds tests for processing guard, abort behavior, and regenerate behavior with AIMessage |
7b42cea to
8308ed7
Compare
dmirgaev
requested changes
May 12, 2026
dmirgaev
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.