Skip to content

T1328637 - List - Select All checkbox aria-label does not reflect the selectAllText value#33579

Merged
dmlvr merged 1 commit into
DevExpress:26_1from
dmlvr:T1328637_26_1
May 14, 2026
Merged

T1328637 - List - Select All checkbox aria-label does not reflect the selectAllText value#33579
dmlvr merged 1 commit into
DevExpress:26_1from
dmlvr:T1328637_26_1

Conversation

@dmlvr
Copy link
Copy Markdown
Contributor

@dmlvr dmlvr commented May 14, 2026

No description provided.

@dmlvr dmlvr self-assigned this May 14, 2026
@dmlvr dmlvr added the 26_1 label May 14, 2026
@dmlvr dmlvr requested a review from a team as a code owner May 14, 2026 11:32
Copilot AI review requested due to automatic review settings May 14, 2026 11:32
@dmlvr dmlvr changed the title T1328637 - List — Select All checkbox aria-label does not reflect the selectAllText value T1328637 - List - Select All checkbox aria-label does not reflect the selectAllText value May 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DevExtreme List’s “Select All” accessibility labeling so that ARIA labels reflect the selectAllText option (including when changed at runtime), and adds regression tests for T1328637.

Changes:

  • Use selectAllText (instead of the default localized “Select All”) for the Select All checkbox aria-label.
  • Use selectAllText as the prefix for the Select All container aria-label (state suffix remains localized).
  • Add QUnit accessibility coverage for initialization and runtime selectAllText changes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js Adds accessibility regression tests ensuring Select All ARIA labels reflect selectAllText on init and after runtime updates.
packages/devextreme/js/__internal/ui/list/list.edit.decorator.selection.ts Updates Select All checkbox/container ARIA labels to use selectAllText instead of always using the default localization key.

@pharret31 pharret31 self-requested a review May 14, 2026 12:14
@dmlvr dmlvr merged commit a800afd into DevExpress:26_1 May 14, 2026
128 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants