T1328637 - List - Select All checkbox aria-label does not reflect the selectAllText value#33579
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DevExtreme List’s “Select All” accessibility labeling so that ARIA labels reflect the selectAllText option (including when changed at runtime), and adds regression tests for T1328637.
Changes:
- Use
selectAllText(instead of the default localized “Select All”) for the Select All checkboxaria-label. - Use
selectAllTextas the prefix for the Select All containeraria-label(state suffix remains localized). - Add QUnit accessibility coverage for initialization and runtime
selectAllTextchanges.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js | Adds accessibility regression tests ensuring Select All ARIA labels reflect selectAllText on init and after runtime updates. |
| packages/devextreme/js/__internal/ui/list/list.edit.decorator.selection.ts | Updates Select All checkbox/container ARIA labels to use selectAllText instead of always using the default localization key. |
pharret31
approved these changes
May 14, 2026
pharret31
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.