Revert: #33618 Grid Demos csp fix — to verify visual tests regression source#33676
Closed
aleksei-semikozov wants to merge 1 commit into
Closed
Revert: #33618 Grid Demos csp fix — to verify visual tests regression source#33676aleksei-semikozov wants to merge 1 commit into
aleksei-semikozov wants to merge 1 commit into
Conversation
DevExpress#33618)" This reverts commit 685ce5f.
Contributor
Author
|
Diagnostic complete. Reverting #33618 does NOT fix the regression — same 4 jquery tests still fail. Root cause identified separately: timing issue with remote-data demos (DataGrid/AIColumns hitting OpenAI proxy, DataGrid/RemoteVirtualScrolling + RemoteGrouping + PivotGrid/WebAPIService hitting js.devexpress.com Sales API). Screenshot capture happens before async data finishes loading. See diff artifacts: 'Loading...' text visible in actual screenshots; affected demos all fetch from external sources. Likely catalyst: #33639 (Demos: DataGrid/TreeList aicolumn — handle inline module) which changed JS loading timing for AI demos. Real fix needed: increase screenshot wait timeouts, mock external data in CI, or skip AI/Remote demos in visual tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic revert of #33618 (Grid Demos: fix csp in treelist-overview and grid-rowselection).
Purpose: confirm that #33618 (merged 2026-05-19 12:51 as commit
685ce5f5) is the root cause of jquery screenshot test regression on 26_1.Evidence pointing at #33618:
685ce5f5: all jquery screenshot tests pass stably on master 26_1685ce5f5:jquery(2/3)-materialstarts failing — first crackBisection summary (visual-tests-demos.yml on 26_1):
36c73f41312163ac685ce5f574714d8ed9629585Diagnostic PRs already done:
Expected outcome: if jquery tests pass on this revert PR, #33618 is the root cause and team needs to: