Skip to content

AI Assistant: add filter value to command default message#33817

Merged
anna-shakhova merged 2 commits into
DevExpress:26_1from
anna-shakhova:26_1__ai_assistant_filter_value
Jun 3, 2026
Merged

AI Assistant: add filter value to command default message#33817
anna-shakhova merged 2 commits into
DevExpress:26_1from
anna-shakhova:26_1__ai_assistant_filter_value

Conversation

@anna-shakhova
Copy link
Copy Markdown
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Jun 3, 2026
@anna-shakhova anna-shakhova marked this pull request as ready for review June 3, 2026 13:01
@anna-shakhova anna-shakhova requested a review from a team as a code owner June 3, 2026 13:01
Copilot AI review requested due to automatic review settings June 3, 2026 13:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves AI Assistant command feedback for filtering actions in DevExtreme grids by generating a human-readable filter description (based on the grid’s filter panel formatting) and ensuring long command messages remain discoverable in the UI.

Changes:

  • Generate a richer default success/failure message for the filterValue AI command by appending formatted filter text (e.g., Apply a filter: [Name] Equals 'Alpha'.).
  • Improve command list UX in the AI chat UI by clamping long command text to two lines and exposing the full text via the title attribute on hover.
  • Add/adjust unit tests to verify the new message formatting and the title attribute behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_panel.ts Exposes getFilterText publicly (typed) so AI commands can reuse the filter panel’s human-readable formatting.
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts Adds title attribute to command message text elements for full-message hover visibility.
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts Adds coverage for the new title attribute behavior in command rendering.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts Enhances filterValue command messaging by appending formatted filter text via filterPanelView.getFilterText.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/filtering.test.ts Updates tests to expect the richer filter message and refines failure mocking to target only filter application.
packages/devextreme-scss/scss/widgets/base/gridBase/layout/aiChat/_variables.scss Introduces a variable controlling maximum visible lines for command text items.
packages/devextreme-scss/scss/widgets/base/gridBase/layout/aiChat/_index.scss Applies multi-line clamping styles to AI chat command message text.

@anna-shakhova anna-shakhova force-pushed the 26_1__ai_assistant_filter_value branch from 6b0d9b1 to edafcd9 Compare June 3, 2026 13:14
@anna-shakhova anna-shakhova merged commit b7f09f3 into DevExpress:26_1 Jun 3, 2026
103 checks passed
@anna-shakhova anna-shakhova deleted the 26_1__ai_assistant_filter_value branch June 3, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants