AI Assistant: add filter value to command default message#33817
Merged
anna-shakhova merged 2 commits intoJun 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves AI Assistant command feedback for filtering actions in DevExtreme grids by generating a human-readable filter description (based on the grid’s filter panel formatting) and ensuring long command messages remain discoverable in the UI.
Changes:
- Generate a richer default success/failure message for the
filterValueAI command by appending formatted filter text (e.g.,Apply a filter: [Name] Equals 'Alpha'.). - Improve command list UX in the AI chat UI by clamping long command text to two lines and exposing the full text via the
titleattribute on hover. - Add/adjust unit tests to verify the new message formatting and the
titleattribute behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_panel.ts | Exposes getFilterText publicly (typed) so AI commands can reuse the filter panel’s human-readable formatting. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts | Adds title attribute to command message text elements for full-message hover visibility. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts | Adds coverage for the new title attribute behavior in command rendering. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts | Enhances filterValue command messaging by appending formatted filter text via filterPanelView.getFilterText. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/filtering.test.ts | Updates tests to expect the richer filter message and refines failure mocking to target only filter application. |
| packages/devextreme-scss/scss/widgets/base/gridBase/layout/aiChat/_variables.scss | Introduces a variable controlling maximum visible lines for command text items. |
| packages/devextreme-scss/scss/widgets/base/gridBase/layout/aiChat/_index.scss | Applies multi-line clamping styles to AI chat command message text. |
6b0d9b1 to
edafcd9
Compare
Alyar666
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.