AI Assistant: validate filter field existence for filter command#33830
Merged
anna-shakhova merged 1 commit intoJun 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens validation for the Grid AI Assistant’s filterValue command by ensuring every basic filter expression targets an existing grid column, preventing invalid filter sync behavior.
Changes:
- Validate
expr.fieldby resolving the corresponding column viacolumnOption, and fail the command when the column does not exist. - Use the resolved column’s
dataTypewhen normalizing filter values (instead of queryingdataTypedirectly). - Add Jest coverage for unknown fields and for filtering on hidden-but-existing columns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts | Adds column existence validation for basic filter nodes and updates the command description to require existing columns. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/filtering.test.ts | Adds tests ensuring unknown fields fail without applying filterValue, and hidden columns still allow filtering. |
Raushen
approved these changes
Jun 4, 2026
dmirgaev
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.