Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import type { Properties as SwitchProperties } from '@js/ui/switch';
import type { Properties as TextAreaProperties } from '@js/ui/text_area';
import { current, isFluent } from '@js/ui/themes';
import { dateSerialization } from '@ts/core/utils/m_date_serialization';
import DropDownEditor from '@ts/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '@ts/ui/drop_down_editor/drop_down_editor';
import type Popup from '@ts/ui/popup/m_popup';

import timeZoneUtils from '../m_utils_time_zone';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { DeferredObj } from '@js/core/utils/deferred';
import type { Properties } from '@js/ui/color_box';
import type { OptionChanged } from '@ts/core/widget/types';
import Color from '@ts/m_color';
import DropDownEditor from '@ts/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '@ts/ui/drop_down_editor/drop_down_editor';
import type { ValueChangedEvent } from '@ts/ui/editor/editor';

import type { PopupProperties } from '../popup/m_popup';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import type {
} from '@js/ui/date_box';
import type { ToolbarItem } from '@js/ui/popup';
import type { OptionChanged } from '@ts/core/widget/types';
import DropDownEditor from '@ts/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '@ts/ui/drop_down_editor/drop_down_editor';
import type { ValueChangedEvent } from '@ts/ui/editor/editor';

import type { PopupProperties } from '../popup/m_popup';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import dateSerialization from '@js/core/utils/date_serialization';
import { getHeight, getOuterHeight } from '@js/core/utils/size';
import { isDate } from '@js/core/utils/type';
import { getWindow } from '@js/core/utils/window';
import { getSizeValue } from '@ts/ui/drop_down_editor/m_utils';
import { getSizeValue } from '@ts/ui/drop_down_editor/utils';
import List from '@ts/ui/list/list.edit.search';

import type { PopupProperties } from '../popup/m_popup';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { each } from '@js/core/utils/iterator';
import type { Properties } from '@js/ui/date_range_box';
import Editor from '@js/ui/editor/editor';
import { current, isFluent, isMaterial } from '@js/ui/themes';
import DropDownButton from '@ts/ui/drop_down_editor/m_drop_down_button';
import DropDownButton from '@ts/ui/drop_down_editor/drop_down_button';
import ClearButton from '@ts/ui/text_box/text_editor.clear';
import TextEditorButtonCollection from '@ts/ui/text_box/texteditor_button_collection/index';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import Button from '@js/ui/button';

import type TextEditorBase from '../text_box/text_editor.base';
import TextEditorButton from '../text_box/texteditor_button_collection/button';
import type DropDownEditor from './m_drop_down_editor';
import type { DropDownEditorProperties } from './m_drop_down_editor';
import type DropDownEditor from './drop_down_editor';
import type { DropDownEditorProperties } from './drop_down_editor';

const DROP_DOWN_EDITOR_BUTTON_CLASS = 'dx-dropdowneditor-button';
const DROP_DOWN_EDITOR_BUTTON_VISIBLE = 'dx-dropdowneditor-button-visible';
Expand Down Expand Up @@ -125,7 +125,6 @@ export default class DropDownButton extends TextEditorButton {
}

// TODO: get rid of it
// eslint-disable-next-line class-methods-use-this
_legacyRender(
$editor?: dxElementWrapper,
$element?: dxElementWrapper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ import TextBox from '@ts/ui/text_box/text_box';

import type Popover from '../popover/m_popover';
import type { TextEditorButtonInfo } from '../text_box/texteditor_button_collection/index';
import DropDownButton from './m_drop_down_button';
import { getElementWidth, getSizeValue } from './m_utils';
import DropDownButton from './drop_down_button';
import { getElementWidth, getSizeValue } from './utils';

export const DROP_DOWN_EDITOR_CLASS = 'dx-dropdowneditor';
const DROP_DOWN_EDITOR_INPUT_WRAPPER = 'dx-dropdowneditor-input-wrapper';
Expand Down Expand Up @@ -261,12 +261,10 @@ class DropDownEditor<
};
}

// eslint-disable-next-line class-methods-use-this
_useTemplates(): boolean {
return true;
}

// eslint-disable-next-line class-methods-use-this
_getDefaultPopupPosition(isRtlEnabled?: boolean): PositionConfig {
const position = getDefaultAlignment(isRtlEnabled);

Expand Down Expand Up @@ -377,17 +375,14 @@ class DropDownEditor<
.eq(0);
}

// eslint-disable-next-line class-methods-use-this
_getAriaHasPopup(): string {
return 'true';
}

// eslint-disable-next-line class-methods-use-this
_getAriaAutocomplete(): string {
return 'none';
}

// eslint-disable-next-line class-methods-use-this
_getAriaRole(): string {
return 'combobox';
}
Expand Down Expand Up @@ -818,7 +813,6 @@ class DropDownEditor<
this.setAria('label', OVERLAY_CONTENT_LABEL, $overlayContent);
}

// eslint-disable-next-line class-methods-use-this
_renderPopupContent(): void {}

_renderPopup(): void {
Expand Down Expand Up @@ -883,7 +877,6 @@ class DropDownEditor<
this.setAria('id', this._popupContentId, $popupContent);
}

// eslint-disable-next-line class-methods-use-this
_contentReadyHandler(): void {}

_popupConfig(): PopupProperties {
Expand Down Expand Up @@ -927,7 +920,6 @@ class DropDownEditor<
};
}

// eslint-disable-next-line class-methods-use-this
_popupInitializedHandler(): void {}

_getPopupInitializedHandler(): (e: PopupInitializedEvent) => void {
Expand Down Expand Up @@ -986,7 +978,6 @@ class DropDownEditor<
}
}

// eslint-disable-next-line class-methods-use-this
_popupShowingHandler(): void {}

_popupHidingHandler(): void {
Expand Down Expand Up @@ -1173,7 +1164,6 @@ class DropDownEditor<
return super._getSubmitElement();
}

// eslint-disable-next-line class-methods-use-this
_shouldLogFieldTemplateDeprecationWarning(): boolean {
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import errors from '@js/ui/widget/ui.errors';
import type { OptionChanged } from '@ts/core/widget/types';
import { getDataSourceOptions } from '@ts/data/data_converter/grouped';
import type DataController from '@ts/ui/collection/m_data_controller';
import DropDownEditor from '@ts/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '@ts/ui/drop_down_editor/drop_down_editor';
import type { ListBaseProperties } from '@ts/ui/list/list.base';
import List from '@ts/ui/list/list.edit.search';

Expand Down Expand Up @@ -67,6 +67,7 @@ class DropDownList<

_listId?: string;

// eslint-disable-next-line no-restricted-globals
_searchTimer?: ReturnType<typeof setTimeout>;

_isLastMinSearchLengthExceeded?: boolean;
Expand Down Expand Up @@ -252,7 +253,6 @@ class DropDownList<
}
}

// eslint-disable-next-line class-methods-use-this
_fitIntoRange(value: number, start: number, end: number): number {
if (value > end) {
return start;
Expand Down Expand Up @@ -312,7 +312,6 @@ class DropDownList<
}
}

// eslint-disable-next-line class-methods-use-this
_popupWrapperClass(): string {
return DROPDOWNLIST_POPUP_WRAPPER_CLASS;
}
Expand Down Expand Up @@ -574,7 +573,6 @@ class DropDownList<
this.setAria('owns', this._popup && this._popupContentId);
}

// eslint-disable-next-line class-methods-use-this
_getAriaHasPopup(): string {
return 'listbox';
}
Expand All @@ -591,7 +589,6 @@ class DropDownList<
return Boolean(dataSource) !== this._needPassDataSourceToList();
}

// eslint-disable-next-line class-methods-use-this
_isDesktopDevice(): boolean {
return devices.real().deviceType === 'desktop';
}
Expand Down Expand Up @@ -644,7 +641,6 @@ class DropDownList<
return options;
}

// eslint-disable-next-line class-methods-use-this
_canListHaveFocus(): boolean {
return false;
}
Expand All @@ -653,7 +649,6 @@ class DropDownList<
return this._needPassDataSourceToList() ? this._dataSource : null;
}

// eslint-disable-next-line class-methods-use-this
_dataSourceOptions(): Partial<DataSourceOptions<Item>> {
return {
paginate: false,
Expand All @@ -673,7 +668,6 @@ class DropDownList<
return dataSource;
}

// eslint-disable-next-line class-methods-use-this
_dataSourceFromUrlLoadMode(): string {
return 'raw';
}
Expand Down Expand Up @@ -710,7 +704,7 @@ class DropDownList<
this._itemClickAction(e);
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars, class-methods-use-this
// eslint-disable-next-line @typescript-eslint/no-unused-vars
_listItemClickHandler(e?: ItemClickEvent<Item>): void { }

_setListDataSource(): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import type {
import type {
FormItemComponent, FormLabelMode, LabelLocation, SimpleItem,
} from '@js/ui/form';
import type { DropDownEditorProperties } from '@ts/ui/drop_down_editor/m_drop_down_editor';
import type { DropDownEditorProperties } from '@ts/ui/drop_down_editor/drop_down_editor';
import type { EditorProperties } from '@ts/ui/editor/editor';
import type Editor from '@ts/ui/editor/editor';
import type { LabelOptions } from '@ts/ui/form/components/label';
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/ui/form/form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import type { OptionChanged } from '@ts/core/widget/types';
import type { SupportedKeyHandler } from '@ts/core/widget/widget';
import Widget, { FOCUSED_STATE_CLASS } from '@ts/core/widget/widget';
import type { Button } from '@ts/ui/button/button';
import { DROP_DOWN_EDITOR_CLASS } from '@ts/ui/drop_down_editor/m_drop_down_editor';
import { DROP_DOWN_EDITOR_CLASS } from '@ts/ui/drop_down_editor/drop_down_editor';
import Editor from '@ts/ui/editor/editor';
import { setLabelWidthByMaxLabelWidth } from '@ts/ui/form/components/label';
import {
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/ui/m_autocomplete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { extend } from '@js/core/utils/extend';
import type { Properties } from '@js/ui/autocomplete';
import { isDefined } from '@ts/core/utils/m_type';
import type { OptionChanged } from '@ts/core/widget/types';
import DropDownList from '@ts/ui/drop_down_editor/m_drop_down_list';
import DropDownList from '@ts/ui/drop_down_editor/drop_down_list';

const AUTOCOMPLETE_CLASS = 'dx-autocomplete';
const AUTOCOMPLETE_POPUP_WRAPPER_CLASS = 'dx-autocomplete-popup-wrapper';
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/ui/m_drop_down_box.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type { Properties } from '@js/ui/drop_down_box';
import DataExpressionMixin from '@js/ui/editor/ui.data_expression';
import type { Properties as PopupProperties } from '@js/ui/popup';
import { tabbable } from '@ts/core/utils/m_selectors';
import DropDownEditor from '@ts/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '@ts/ui/drop_down_editor/drop_down_editor';
import { getElementMaxHeightByWindow } from '@ts/ui/overlay/utils';

const { getActiveElement } = domAdapter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import ButtonGroup from '@js/ui/button_group';
import type { Item, Properties } from '@js/ui/drop_down_button';
import type { OptionChanged } from '@ts/core/widget/types';
import Widget from '@ts/core/widget/widget';
import { getElementWidth, getSizeValue } from '@ts/ui/drop_down_editor/m_utils';
import { getElementWidth, getSizeValue } from '@ts/ui/drop_down_editor/utils';
import type { ListBaseProperties } from '@ts/ui/list/list.base';
import List from '@ts/ui/list/list.edit.search';
import type { PopupProperties } from '@ts/ui/popup/m_popup';
Expand Down
4 changes: 2 additions & 2 deletions packages/devextreme/js/__internal/ui/m_lookup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import Popover from '@js/ui/popover/ui.popover';
import { current, isMaterial } from '@js/ui/themes';
import supportUtils from '@ts/core/utils/m_support';
import type { OptionChanged } from '@ts/core/widget/types';
import DropDownList from '@ts/ui/drop_down_editor/m_drop_down_list';
import { getElementWidth } from '@ts/ui/drop_down_editor/m_utils';
import DropDownList from '@ts/ui/drop_down_editor/drop_down_list';
import { getElementWidth } from '@ts/ui/drop_down_editor/utils';
import TextBox from '@ts/ui/text_box/text_box';

const window = getWindow();
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/ui/m_select_box.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { extend } from '@js/core/utils/extend';
import { each } from '@js/core/utils/iterator';
import { isDefined, isPromise } from '@js/core/utils/type';
import type { Properties } from '@js/ui/select_box';
import DropDownList from '@ts/ui/drop_down_editor/m_drop_down_list';
import DropDownList from '@ts/ui/drop_down_editor/drop_down_list';

import type { ValueChangedEvent } from './editor/editor';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import DropDownEditor from '../../__internal/ui/drop_down_editor/m_drop_down_editor';
import DropDownEditor from '../../__internal/ui/drop_down_editor/drop_down_editor';

export default DropDownEditor;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import DropDownList from '../../__internal/ui/drop_down_editor/m_drop_down_list';
import DropDownList from '../../__internal/ui/drop_down_editor/drop_down_list';

export default DropDownList;

Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/testing/helpers/diagramHelpers.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import $ from 'jquery';
import diagramContextMenuModule from '__internal/ui/diagram/ui.diagram.context_menu';
import { DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON } from '__internal/ui/drop_down_editor/m_drop_down_editor';
import { DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON } from '__internal/ui/drop_down_editor/drop_down_editor';

export const Consts = {
SIMPLE_DIAGRAM: '{ "shapes": [{ "key":"107", "type":"Ellipsis", "text":"A new ticket", "x":1440, "y":1080, "width":1440, "height":720, "zIndex":0 }] }',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Deferred } from 'core/utils/deferred';
import {
DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON,
DROP_DOWN_EDITOR_AFTER_FIELD_ADDON
} from '__internal/ui/drop_down_editor/m_drop_down_editor';
} from '__internal/ui/drop_down_editor/drop_down_editor';

import 'ui/drop_down_editor/ui.drop_down_editor';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import domAdapter from '__internal/core/m_dom_adapter';
import {
DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON,
DROP_DOWN_EDITOR_AFTER_FIELD_ADDON
} from '__internal/ui/drop_down_editor/m_drop_down_editor';
} from '__internal/ui/drop_down_editor/drop_down_editor';

import 'fluent_blue_light.css!';
import 'ui/validator';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'ui/diagram';
import { DiagramCommand } from 'devexpress-diagram';
import { Consts, getMainToolbarInstance, findMainToolbarItem, getToolbarIcon, findContextMenuItem } from '../../../helpers/diagramHelpers.js';
import { getActiveElement } from '../../../helpers/shadowDom.js';
import { DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON } from '__internal/ui/drop_down_editor/m_drop_down_editor';
import { DROP_DOWN_EDITOR_BEFORE_FIELD_ADDON } from '__internal/ui/drop_down_editor/drop_down_editor';

const moduleConfig = {
beforeEach: function() {
Expand Down
Loading