Lookup: Improve types#33868
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving TypeScript typings in the internal Lookup implementation, reducing any usage and clarifying event/data types. It also exposes a shared FieldTemplate type from the internal drop-down editor module so Lookup can type its field template rendering more precisely.
Changes:
- Added/updated a number of explicit types in
m_lookup.ts(events, datasource options, toolbar items, return types) and replaced some iterator helpers with typed array iteration. - Refactored option access patterns to use object destructuring and optional chaining for clearer typing.
- Exported
FieldTemplatefrom the internal drop-down editor so it can be imported and used byLookup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/m_lookup.ts |
Adds stronger typings across the Lookup widget, including events, popup/list config, and template rendering. |
packages/devextreme/js/__internal/ui/drop_down_editor/drop_down_editor.ts |
Exports FieldTemplate for reuse in internal consumers like Lookup. |
marker-dao
previously approved these changes
Jun 5, 2026
r-farkhutdinov
force-pushed
the
26_1_lookup_types
branch
from
50affd4 to
e5484d6
Compare
marker-dao
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.