Scheduler: workspace refactor — pass config object instead of workspace for groupedStrategy#33957
Merged
bit-byte0 merged 1 commit intoJun 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Scheduler grouped strategies to depend on a narrower GroupedStrategyConfig contract instead of the full workspace instance, with the goal of removing workspace coupling and eliminating @ts-expect-error usage in the strategy implementations.
Changes:
- Introduced
GroupedStrategyConfigto encapsulate only the APIs grouped strategies need. - Updated horizontal/vertical grouped strategies to consume
configinstead ofworkspace. - Updated
SchedulerWorkSpaceto create and pass a boundconfigobject into the selected grouped strategy.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_vertical.ts | Replaced workspace dependencies with GroupedStrategyConfig calls in the vertical strategy. |
| packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_horizontal.ts | Replaced workspace dependencies with GroupedStrategyConfig calls in the horizontal strategy. |
| packages/devextreme/js/__internal/scheduler/workspaces/work_space_grouped_strategy_config.ts | Added the new GroupedStrategyConfig interface used by grouped strategies. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Added createGroupedStrategyConfig() and updated grouped-strategy instantiation to pass the config object. |
bit-byte0
force-pushed
the
refactor/scheduler-grouped-strategy-pass-config
branch
from
67a4611 to
2f75943
Compare
bit-byte0
force-pushed
the
refactor/scheduler-grouped-strategy-pass-config
branch
from
9e03880 to
31442de
Compare
bit-byte0
force-pushed
the
refactor/scheduler-grouped-strategy-pass-config
branch
from
31442de to
d5cc496
Compare
aleksei-semikozov
approved these changes
Jun 11, 2026
Tucchhaa
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Grouped strategies no longer depend on the entire workspace object
How:
Extracted a
GroupedStrategyConfiginterface with only the methods/options strategies actually use. Workspace passes aconfigobject with bound closures instead of this. Removed all@ts-expect-errorlines from both strategy files.