Skip to content

CI: fix wrapper_tests on chrome install step#34226

Merged
alexslavr merged 1 commit into
DevExpress:26_1from
EugeniyKiyashko:26_1_fix_wrapper_tests
Jul 8, 2026
Merged

CI: fix wrapper_tests on chrome install step#34226
alexslavr merged 1 commit into
DevExpress:26_1from
EugeniyKiyashko:26_1_fix_wrapper_tests

Conversation

@EugeniyKiyashko

Copy link
Copy Markdown
Contributor

No description provided.

@EugeniyKiyashko EugeniyKiyashko self-assigned this Jul 7, 2026
Copilot AI review requested due to automatic review settings July 7, 2026 16:50
@EugeniyKiyashko EugeniyKiyashko requested a review from a team as a code owner July 7, 2026 16:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the wrapper test CI flow (Angular) to work with newer Puppeteer/Chrome behavior by making the Karma config load path support async configuration and by refreshing the Puppeteer/Chrome versions used in CI.

Changes:

  • Bump puppeteer for devextreme-angular and update pnpm-lock.yaml accordingly.
  • Allow async Karma config parsing by passing promiseConfig/throwErrors into karma.config.parseConfig(...) and reflecting that in local Karma typings.
  • Adjust the GitHub Actions wrapper test workflow to install a newer Chrome version and proactively purge a corrupted Puppeteer cache directory.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Lockfile refresh to reflect Puppeteer and related dependency updates.
packages/nx-infra-plugin/src/executors/karma-multi-env/karma-utils.ts Extends the local Karma module typing to allow parse options.
packages/nx-infra-plugin/src/executors/karma-multi-env/karma-multi-env.impl.ts Parses Karma config with async-aware options (promiseConfig) and stricter error behavior (throwErrors).
packages/devextreme-angular/package.json Updates Puppeteer dev dependency version used by Angular wrapper tests.
packages/devextreme-angular/karma.conf.js Converts Karma config export to async and awaits Puppeteer’s executablePath().
.github/workflows/wrapper_tests.yml Updates Chrome download/install step and adds a corrupted-cache cleanup guard.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

@EugeniyKiyashko EugeniyKiyashko requested review from a team as code owners July 7, 2026 17:01
Copilot AI review requested due to automatic review settings July 7, 2026 17:01
@EugeniyKiyashko EugeniyKiyashko force-pushed the 26_1_fix_wrapper_tests branch from c25431a to 06c63ad Compare July 7, 2026 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

@EugeniyKiyashko EugeniyKiyashko added this pull request to the merge queue Jul 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 8, 2026
@alexslavr alexslavr merged commit f018530 into DevExpress:26_1 Jul 8, 2026
159 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants