CI: fix wrapper_tests on chrome install step#34226
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the wrapper test CI flow (Angular) to work with newer Puppeteer/Chrome behavior by making the Karma config load path support async configuration and by refreshing the Puppeteer/Chrome versions used in CI.
Changes:
- Bump
puppeteerfordevextreme-angularand updatepnpm-lock.yamlaccordingly. - Allow async Karma config parsing by passing
promiseConfig/throwErrorsintokarma.config.parseConfig(...)and reflecting that in local Karma typings. - Adjust the GitHub Actions wrapper test workflow to install a newer Chrome version and proactively purge a corrupted Puppeteer cache directory.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Lockfile refresh to reflect Puppeteer and related dependency updates. |
packages/nx-infra-plugin/src/executors/karma-multi-env/karma-utils.ts |
Extends the local Karma module typing to allow parse options. |
packages/nx-infra-plugin/src/executors/karma-multi-env/karma-multi-env.impl.ts |
Parses Karma config with async-aware options (promiseConfig) and stricter error behavior (throwErrors). |
packages/devextreme-angular/package.json |
Updates Puppeteer dev dependency version used by Angular wrapper tests. |
packages/devextreme-angular/karma.conf.js |
Converts Karma config export to async and awaits Puppeteer’s executablePath(). |
.github/workflows/wrapper_tests.yml |
Updates Chrome download/install step and adds a corrupted-cache cleanup guard. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
c25431a to
06c63ad
Compare
vorobey
approved these changes
Jul 8, 2026
alexslavr
approved these changes
Jul 8, 2026
alexslavr
pushed a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.