Drop the verification-unavailable prompt with strict plan verification - #51
Merged
Merged
Conversation
Follows the CLI change that removes the second-model step verifier. The prompt offering "Retry verification" or "Pause plan" had nothing left to retry, and the plan editor no longer needs to reset an evidence-follow-up flag that no longer exists. Submodule bump carries the planner change itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this was done
The paired MandoCode PR removes the second-model step verifier from the planner. This is the Desktop half of that removal.
Desktop had a modal approval prompt — "Step N: verification unavailable" offering Retry verification or Pause plan — that fired when the verifier failed to return a usable verdict. With no verifier, nothing can produce that state and there is nothing to retry, so the dialog is unreachable code that would confuse the next person to read
ChatController.What changed
StepVerificationUnavailablecase and its approval dialog fromChatController.EvidenceFollowupUsedreset fromPlanInstructionEditor. Editing a step still resets its acceptance criteria to the newly typed instruction — that behavior, added in Show each plan step's acceptance checks on the review card #50, is untouched. Only the flag for a follow-up mechanism that no longer exists is gone.Impact
No user-visible behavior is lost. The dialog only ever appeared when the verifier malfunctioned; that component is gone. Plan review, acceptance checks on the review card, step editing, pause, and
/plan-resumeall behave as they do today.Risk
Low. Two deletions in view-model code, one submodule bump.
Merge order
Merge the MandoCode PR first, then confirm this branch's submodule pointer resolves to a commit on CLI
mainbefore merging here.Testing
Desktop suite green: 243 passed, 0 failed. Desktop builds clean against the updated submodule.