fix(renovate): drop invalid minimumReleaseAge override on automerge rule - #285
Merged
DevSecNinja merged 1 commit intoJul 27, 2026
Merged
Conversation
The automerge packageRule set `minimumReleaseAge: "null"` — the string
"null", not JSON null — which is not a valid duration and is silently
ignored by Renovate. Even as real `null` it would waive the soak, which
directly contradicts the rule's own comment ("Risk is covered by the
global minimumReleaseAge soak time in base.json5") and the intent of
ADR 0004 (automerge non-major only after the soak).
Remove the line so automerge updates correctly inherit the global
14-day `minimumReleaseAge` soak. No behaviour change for container
images (the docker rule in packageRules.json5 already enforces 14 days);
this fixes the latent bug and removes the misleading config.
Refs DevSecNinja/truenas-apps#115
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DevSecNinja
deleted the
fix/renovate-drop-invalid-automerge-minreleaseage
branch
July 27, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The automerge
packageRulein.renovate/autoMerge.json5sets:This is the string
"null", not JSONnull. It is not a valid duration, so Renovate silently ignores it. Worse, even if it were realnullit would waive the soak — directly contradicting the rule's own comment:…and the intent of ADR 0004 (auto-merge non-major updates only after the soak).
Fix
Remove the line so automerge updates inherit the global
minimumReleaseAge: "14 days"frombase.json5, as the comment and ADR intend.No behaviour change for container images —
packageRules.json5's docker rule already enforces14 daysand is applied later. This just removes dead/misleading config and fixes the latent bug.Follow-up to #284. Refs DevSecNinja/truenas-apps#115