feat: measure references, M365 Maps link, SEO metadata, Playwright E2E and a new header logo - #66
Merged
Merged
Conversation
Integrates the brand G-badge (gradient #2f6df6 to #7c3aed with white G mark, matching the favicon/icons) as an inline, themeable SVG in the top-left header. Adds an accessible logoAlt aria-label in nl/en/fr. Closes #31
Contributor
|
🔍 Preview deployed: https://1ca44c2a.grip-visualizer.pages.dev Updated: Thu, 18 Jun 2026 15:23:39 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A single PR bundling four issues plus the new header logo.
#63— "Further reading" references on measuresreferences[]field on measures in src/data/grip.json (localizedlabel_nl/en/fr+url), seeded on measure O7 (authentication policy).#38.referencesTitlestrings (nl/en/fr).#62— M365 Maps reference linkm365MapsLinkstrings (nl/en/fr).#22— SEO / social metadataWebApplication.public/:robots.txt,sitemap.xml,site.webmanifest,og-image.png,icon-192.png,icon-512.png,apple-touch-icon.png(gradient brand mark).#26— Playwright end-to-end testse2e/app.spec.js,e2e/mobile.spec.js..github/workflows/e2e.yml(SHA-pinned actions),test:e2escripts,@playwright/testdev dependency, Vitest scoped tosrc/**so it ignores the e2e specs.#31— Header logoGRIP × MSFTtext lockup in AppHeader.jsx with an inline, themeable gradient G-badge SVG (matching the favicon/icons), plus an accessiblelogoAltaria-label (nl/en/fr).Validation
npm run lint— cleannpm test— 16 unit tests passnpm run test:e2e— E2E pass (7 desktop chromium + mobile projects)Note:
grip.jsonis intentionally left in the repo's existing (non-Prettier) formatting; only changed JS/CSS files were Prettier-formatted.Closes #63
Closes #62
Closes #22
Closes #26
Closes #31