Skip to content

fix: harden v0.2.1 Homebrew smoke readiness - #47

Merged
DevVig merged 1 commit into
mainfrom
fix/v0.2.1-release-smoke
Jul 18, 2026
Merged

fix: harden v0.2.1 Homebrew smoke readiness#47
DevVig merged 1 commit into
mainfrom
fix/v0.2.1-release-smoke

Conversation

@DevVig

@DevVig DevVig commented Jul 18, 2026

Copy link
Copy Markdown
Owner

What changed

  • wait for marker, service state, and app process readiness on macOS runners
  • read the app version directly from Info.plist with PlistBuddy
  • dump Homebrew service and daemon diagnostics before cleanup on failure
  • apply the same readiness checks to final public-install verification

Evidence

  • failed v0.2.1 release artifacts were downloaded and exercised directly on Apple Silicon
  • packaged microbridged remained alive and listened on an isolated socket
  • signed Microbridge.app reported 0.2.1, passed codesign verification, and remained alive
  • bash syntax, workflow YAML parse, and git diff checks pass

This repairs the smoke harness that stopped release run 29656672177 before any prerelease was published.

Copilot AI review requested due to automatic review settings July 18, 2026 19:02
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca6fb036-1f10-415a-a39f-4a631bc63ad0

📥 Commits

Reviewing files that changed from the base of the PR and between d13db7b and 9441352.

📒 Files selected for processing (2)
  • .github/workflows/finalize-release.yml
  • scripts/smoke-formula.sh

Comment @coderabbitai help to get the list of available commands.

@DevVig
DevVig merged commit ffb31ac into main Jul 18, 2026
8 checks passed
@DevVig
DevVig deleted the fix/v0.2.1-release-smoke branch July 18, 2026 19:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens the macOS Homebrew smoke/verification harness for v0.2.1 by extending readiness waits, validating the installed app version from Info.plist, and capturing diagnostics on failures so release finalization is less prone to flaky runner timing.

Changes:

  • Add a failure-only diagnostics path to the formula smoke script (services status + log tail + bundle metadata).
  • Replace defaults read with PlistBuddy for CFBundleShortVersionString reads.
  • Expand readiness loops and apply equivalent checks to the public-install verification in the release finalization workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/smoke-formula.sh Adds diagnostics-on-failure and strengthens brew/app readiness checks in the local formula smoke harness.
.github/workflows/finalize-release.yml Applies the same readiness checks to the final “public tap install” verification step before promoting a release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/smoke-formula.sh
APP_PID=""
for _ in {1..10}; do
for _ in {1..30}; do
APP_PID="$(pgrep -f "$APP/Contents/MacOS/" | head -1 || true)"
APP_PID=""
for _ in {1..10}; do
for _ in {1..30}; do
APP_PID="$(pgrep -f "$APP/Contents/MacOS/" | head -1 || true)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants