fix: launch app directly in headless Homebrew smoke - #48
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS Homebrew smoke verification to launch the installed Microbridge UI executable directly (instead of using open) so the checks are deterministic on headless CI runners, and improves diagnostics by capturing UI output to a log file.
Changes:
- Run
Microbridge.app/Contents/MacOS/microbridge-uidirectly during smoke and public-install verification instead of relying on Launch Services (open). - Add per-run UI log capture and include it in diagnostics / failure output.
- Verify the launched UI process is alive before terminating it, and apply the same approach in the release finalization workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/smoke-formula.sh | Launches the installed UI binary directly during formula smoke tests and adds app log capture to diagnostics. |
| .github/workflows/finalize-release.yml | Updates public-tap install verification to directly run the UI binary and emit app logs when launch verification fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "$APP/Contents/MacOS/microbridge-ui" >"$APP_LOG" 2>&1 & | ||
| APP_PID=$! | ||
| sleep 3 | ||
| kill -0 "$APP_PID" |
| APP_LOG="$RUNNER_TEMP/microbridge-app.log" | ||
| "$APP/Contents/MacOS/microbridge-ui" >"$APP_LOG" 2>&1 & | ||
| APP_PID=$! | ||
| sleep 3 | ||
| if ! kill -0 "$APP_PID"; then | ||
| cat "$APP_LOG" | ||
| exit 1 | ||
| fi |
What changed
Root cause evidence
Release run 29657076770 proved on both architectures that the formula installs, the marker and 0.2.1 app bundle exist, the daemon binds its socket, and Homebrew reports the service started. The only failing assertion was waiting for Launch Services (
open) to expose a GUI PID in a headless runner. Direct execution is the deterministic CI launch boundary.