fix(ci): prevent npm lifecycle scripts and remove persisted checkout credentials in lint/test - #11
Open
DeveloperDurp wants to merge 1 commit into
Open
fix(ci): prevent npm lifecycle scripts and remove persisted checkout credentials in lint/test#11DeveloperDurp wants to merge 1 commit into
DeveloperDurp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
static/swagger-ui/by running a Make target that previously invokednpm install, which executes dependency lifecycle scripts and can leak the checkout's job token whenactions/checkoutpersists credentials and the workflow grantspackages: write.//go:embedand templ generation.Description
persist-credentials: falseonactions/checkoutin thelintandtestjobs of.github/workflows/release.ymlso the runner does not leave the GITHUB token in local git config during these jobs.npm-installrecipe fromnpm installtonpm ci --ignore-scriptsso dependency lifecycle scripts are not executed during asset materialization.swagger-ui-copytarget behavior (copying files fromnode_modules/swagger-ui-distintostatic/swagger-ui/) unchanged so//go:embedrequirements continue to be met without running install scripts.Testing
make swagger-ui-copywhich usednpm ci --ignore-scriptsand successfully populatedstatic/swagger-ui/with the expected files.git diff --checkwhich returned no errors.templ generate && go test -v -count=1 ./...but the environment lackedtemplandgo installwas blocked by network/sumdb access, so full test execution is currently blocked by the runtime environment.Codex Task