Stream log exports row-by-row to avoid unbounded memory buffering - #13
Open
DeveloperDurp wants to merge 1 commit into
Open
Stream log exports row-by-row to avoid unbounded memory buffering#13DeveloperDurp wants to merge 1 commit into
DeveloperDurp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Repository.ForEachDeploymentLogByDeploymentAscwhich streams rows viaQueryContextand invokes a callback perdb.DeploymentLogto avoid building a large slice. (internal/repository/repository.go).ExportLogsto write the file header and then stream each formatted log line directly to thehttp.ResponseWriterusing the newForEachDeploymentLogByDeploymentAsccallback instead ofListDeploymentLogsByDeployment+strings.Builder(removes unbounded buffering). (internal/handler/logs.go).ExportLogsso both web and API export paths now stream rows row-by-row. (internal/handler/api/logs.go).Testing
gofmt -landgit diff --checkon the modified files (passed).TestExportLogsunit tests viago test -run 'TestExportLogs' ./internal/handler ./internal/handler/api, but running the tests is blocked in this environment because template-generated packages (temploutputs) are missing andtempl generatecannot be executed here (templ not installed and module proxy access restricted); therefore the export tests could not be executed end-to-end in this session.Stream log exports without buffering).Codex Task