[WiP] bump winit crate#1225
Draft
Mariusz Białończyk (manio) wants to merge 1 commit into
Draft
Conversation
Member
|
Thank you!! |
Contributor
Author
|
If you are asking about keyboard problem, no this update doesn't help, but I found the root cause (here: #535 (comment)) |
irvingouj@Devolutions (irvingoujAtDevolution)
added a commit
that referenced
this pull request
Jul 24, 2026
…nd regenerate bindings Move the diplomat / diplomat-runtime git dependencies from the merged 882006b1 (rust-diplomat/diplomat#1164) to 822b0b3e, the head of irvingoujAtDevolution/diplomat's dotnet-utf-strings branch — currently open as rust-diplomat/diplomat#1225. This pin also carries ~31 other commits already merged into upstream main since the old pin was taken, most notably e827245a ("GC.KeepAlive after native calls to fix mid-call finalization UAF"), a real use-after-free fix in the .NET backend that the previous pin lacked. PR #1225 itself adds zero-copy UTF-8 (`&DiplomatStr`) and UTF-16 (`&DiplomatStr16`) string support plus borrowed string/slice returns (`DiplomatBorrowedSpan<T>`), reusing the existing keep-alive-edge rooting mechanism. CI on the PR is green (24/24), and it includes GC-stress tests proving the new borrowed-return views can't be collected out from under the caller. Also fixed xtask/src/ffi.rs: `cargo xtask ffi install` was installing diplomat-tool from the floating `dotnet-picky-ironrdp-compat` branch, disconnected from the rev actually pinned in ffi/Cargo.toml. Repinned to the same rev for reproducibility. That rev's diplomat_core `hir` feature needs `if let` guards, unsupported by this workspace's pinned 1.89.0 toolchain (rust-toolchain.toml) — install/build diplomat-tool via `rustup run stable` instead, since it's a standalone dev-time codegen binary and doesn't need to match ffi's own toolchain pin. Regenerated C# bindings accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’m creating this PR mainly so that if anyone picks this up, we don’t end up duplicating work. I’ve started migrating winit to the latest beta version. There are quite a lot of changes and still some more work to be done (some parts are commented out/disabled), but I’m sharing the code in its current state anyway.
The winit beta will probably become stable at some point, and at least this way the groundwork is already there.