feat(core): add NonEmpty<T>#1444
Merged
Merged
Conversation
Add a `NonEmpty<T>` collection guaranteeing at least one element. The first element (head) is stored inline, so a single-element `NonEmpty` performs no heap allocation, and `first()` is infallible while `len()` returns a `NonZeroUsize`, and callers never branch on an "is it empty?" case.
There was a problem hiding this comment.
Pull request overview
Adds a small NonEmpty<T> collection to ironrdp-core (behind the alloc feature) to model “at least one element” sequences efficiently: the first element is stored inline to avoid heap allocation for single-element cases, while still providing ergonomic iteration and filtering.
Changes:
- Introduces
NonEmpty<T>with inlinehead+Vec<T>tail, plusfirst(),len() -> NonZeroUsize,iter(), andfilter(). - Implements
IntoIteratorfor both ownedNonEmpty<T>and&NonEmpty<T>. - Wires the module and re-export into
ironrdp-corebehind#[cfg(feature = "alloc")].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/ironrdp-core/src/non_empty.rs | New NonEmpty<T> type with inline head storage, non-zero length, and iterator/filter APIs. |
| crates/ironrdp-core/src/lib.rs | Adds non_empty module and re-exports NonEmpty under the alloc feature gate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vladyslav Nikonov (vnikonov-devolutions)
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
NonEmpty<T>collection guaranteeing at least one element. The first element (head) is stored inline, so a single-elementNonEmptyperforms no heap allocation, andfirst()is infallible whilelen()returns aNonZeroUsize, and callers never branch on an "is it empty?" case.