feat(egfx): composite client surface commands into pixel buffers#1460
Open
Greg Lamberson (glamberson) wants to merge 1 commit into
Open
feat(egfx): composite client surface commands into pixel buffers#1460Greg Lamberson (glamberson) wants to merge 1 commit into
Greg Lamberson (glamberson) wants to merge 1 commit into
Conversation
The client GraphicsPipelineClient decoded WireToSurface1 bitmaps and forwarded every other surface command (SolidFill, SurfaceToSurface, the bitmap cache, MapSurfaceToOutput) to no-op handler callbacks, so it never maintained the pixel state those commands operate on. Against any server that uses them (GNOME Remote Desktop, Windows) the rendered result was wrong. Add a surface compositor that keeps persistent RGBA8888 surfaces and a bitmap cache, applies each command into them, maps surfaces onto the graphics output, and accumulates the changed output regions per frame. The regions are exposed through GraphicsPipelineClient::drain_output(), committed on EndFrame so a partial frame is never observed. Reads and writes are clipped to their buffers, so a malformed server rectangle shrinks the update to empty rather than reading or writing out of range. The existing handler callbacks are kept as secondary notifications, so current consumers are unaffected.
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphicsPipelineClientdecodedWireToSurface1bitmaps but forwardedSolidFill,SurfaceToSurface, the bitmap cache, andMapSurfaceToOutputto no-op handler callbacks, so it never held the pixel state those commands operate on. Any server that uses them (grd, Windows) renders wrong.ironrdp-egfx: persistent RGBA8888 per-surface buffers plus a bitmap cache, applies every surface command, maps surfaces to the output, and accumulates the changed output regions.EndFrameand drained via a newGraphicsPipelineClient::drain_output() -> Vec<OutputUpdate>.GraphicsPipelineHandlercallbacks are retained as notifications, so current consumers are unaffected.Validation
cargo xtask check fmt/lints/tests/typos/locksall pass.Notes
OutputUpdateis#[non_exhaustive], matchingBitmapUpdateandSurface; coordinates useExclusiveRectangle.