Skip to content

feat(iron-remote-desktop): introduce callExtension method in iron-remote-desktop API#799

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
iron-remote-desktop-extension-call-fix
Jun 2, 2025
Merged

feat(iron-remote-desktop): introduce callExtension method in iron-remote-desktop API#799
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
iron-remote-desktop-extension-call-fix

Conversation

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator

@RRRadicalEdward Alex Yusiuk (RRRadicalEdward) commented Jun 2, 2025

No description provided.

CBenoit
Benoît Cortier (CBenoit) approved these changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBenoit Benoît Cortier (CBenoit) merged commit 9f6647c into master Jun 2, 2025
10 checks passed
@CBenoit Benoît Cortier (CBenoit) deleted the iron-remote-desktop-extension-call-fix branch June 2, 2025 18:16
@devolutionsbot devolutionsbot mentioned this pull request Jun 2, 2025
Merged
@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented Jun 2, 2025

suggestion: Consolidate the name of this method to invoke_extension and invokeExtension. I think in the Rust side we called it extension_call, but I feel that you are right to put the verb first here, and I thought that maybe invoke was also slightly better in this case

@RRRadicalEdward
Copy link
Copy Markdown
Collaborator Author

Alex Yusiuk (RRRadicalEdward) commented Jun 3, 2025

suggestion: Consolidate the name of this method to invoke_extension and invokeExtension. I think in the Rust side we called it extension_call, but I feel that you are right to put the verb first here, and I thought that maybe invoke was also slightly better in this case

Addressed in #803

@RRRadicalEdward Alex Yusiuk (RRRadicalEdward) mentioned this pull request Jun 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit Benoît Cortier (CBenoit) CBenoit approved these changes

Assignees

@RRRadicalEdward Alex Yusiuk (RRRadicalEdward)

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RRRadicalEdward @CBenoit @AlexYusiuk