chore: update iron-remote-desktop version to 0.3.1#807
chore: update iron-remote-desktop version to 0.3.1#807Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
iron-remote-desktop version to 0.3.1#807Conversation
| [package] | ||
| name = "iron-remote-desktop" | ||
| version = "0.3.0" | ||
| version = "0.3.1" |
There was a problem hiding this comment.
issue: I think the crate is already up to date, do not bump it
There was a problem hiding this comment.
I'm not sure that in #800, we actually also included #803. It would explain Devolutions/devolutions-gateway#1369 (comment) error
There was a problem hiding this comment.
I verified, it is included (release-plz automatically catch anything related to the Rust code)
See the doc of the latest published version: https://docs.rs/iron-remote-desktop/latest/iron_remote_desktop/trait.Session.html
| ], | ||
| "description": "Web Component providing agnostic implementation for Iron Wasm base client", | ||
| "version": "0.3.0", | ||
| "version": "0.3.1", |
There was a problem hiding this comment.
issue: renaming a method is a breaking change, so this should be 0.4.0 I think
|
Are you sure the latest releases are missing this? In the commit history, the version bump is the latest commit, and so it should includes everything before including the method renaming…
|
|
Alex Yusiuk (@RRRadicalEdward) I think we need to update iron-remote-desktop-rdp, because the latest version we released is still exposing a method |
But iron-remote-desktop-rdp doesn't export |
I’m pretty sure it does. This is part of the API contract defined by |
|
That being said, it’s true that the error is more about the NPM package |
I found the issue reason. I forgot to do the renaming at some more places. I will send a PR |
Alex Yusiuk (RRRadicalEdward)
deleted the
bump-iron-remote-desktop-to-0.3.1
branch
3 participants
It seems that in #800, we released a version that included #799, but not #803, and it's the reason why we have Devolutions/devolutions-gateway#1369 (comment) issue.