Restore IMsRdpClientAdvancedSettingsLB for legacy interop consumers#175
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoJul 24, 2026
Merged
Conversation
#173 removed this hand-written declaration together with the rest of the manual interop surface, because the generated interop types LoadBalanceInfo as BinaryString and no longer needs it. Legacy-interop consumers moving to the current package still do: without it there is no way to set a byte-exact LoadBalanceInfo through the legacy string-typed property. Restored verbatim from 2026.7.3 (dotnet/Devolutions.MsRdpEx/LoadBalanceInfo.cs), relocated into AxInterop.MSTSCLib.Legacy so it ships in the legacy interop assembly and the flavor-neutral Devolutions.MsRdpEx stays MSTSCLib-free.
Copilot started reviewing on behalf of
irvingouj@Devolutions (irvingoujAtDevolution)
July 24, 2026 19:07
View session
There was a problem hiding this comment.
Pull request overview
Restores byte-exact LoadBalanceInfo access for legacy COM interop consumers.
Changes:
- Reintroduces
IMsRdpClientAdvancedSettingsLB. - Places the declaration in the legacy AxInterop assembly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marc-André Moreau (mamoreau-devolutions)
merged commit Jul 24, 2026
24a0ba2
into
master
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#173 removed this hand-written declaration along with the rest of the manual interop surface — the generated interop types
LoadBalanceInfoasBinaryStringand no longer needs it. But legacy-interop consumers on the current package lose their only way to set a byte-exactLoadBalanceInfo.Restored verbatim from
2026.7.3, relocated intoAxInterop.MSTSCLib.Legacyso it ships in the legacy interop assembly andDevolutions.MsRdpExstays MSTSCLib-free.Context: lets RDM bump to the current package (recording-cursor fix, #174) while staying on the legacy interop, without carrying this declaration itself. Verified against RDM: builds clean,
LoadBalanceInfopath unchanged.