Fix #4145 - Fixed self deadlock that hangs the application on icon fetch#4182
Merged
Martí Climent (marticliment) merged 3 commits intoDevolutions:mainfrom Oct 30, 2025
Conversation
Collaborator
|
I will test and merge today or tomorrow |
Martí Climent (marticliment)
approved these changes
Oct 30, 2025
Martí Climent (marticliment)
merged commit 7b8544e
into
Devolutions:main
2 checks passed
Artur Kharin (Taron-art)
deleted the
fix/4145-Opening-shared-package-hangs-the-application
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
There is an issue with TaskRecycler.RunOrAttach - it calls RunOrAttachAsync with block, but inside RunOrAttachAsync (in _runTaskAndWait) there is an await on Task. Because this is called from UI thread, code after await Task must run on UI thread. But since we blocked UI thread in TaskRecycler.RunOrAttach, the program cannot continue.
To fix the problem, _runTaskAndWait (and _runTaskAndWait_VOID for consistency) were updated to allow continue on any thread (using ConfigureAwait(false)). Since there is no UI related code here, it is safe to do that.
Closes #4145